Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(853)

Unified Diff: buildbot/buildbot_pnacl.py

Issue 269703002: Non-SFI Mode: Add nonsfi_loader and plumbing to test it (Closed) Base URL: svn://svn.chromium.org/native_client/trunk/src/native_client
Patch Set: Review Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: buildbot/buildbot_pnacl.py
diff --git a/buildbot/buildbot_pnacl.py b/buildbot/buildbot_pnacl.py
index cb354feee1b0ad0ba7f8f361f17d64fff93d657c..a528b99ed1e9925b10bfd4ca640f0cf6eaf480ae 100755
--- a/buildbot/buildbot_pnacl.py
+++ b/buildbot/buildbot_pnacl.py
@@ -72,6 +72,16 @@ def BuildScriptX86(status, context):
SCons(context, parallel=True, mode=irt_mode,
args=flags_run + ['use_sandboxed_translator=1', 'large_code'])
+ # Test Non-SFI Mode.
+ with Step('nonsfi_tests', status):
+ # The only architectures that the PNaCl toolchain supports Non-SFI
+ # versions of are currently x86-32 and ARM, and ARM testing is covered
+ # by buildbot_pnacl.sh rather than this Python script.
+ if context['default_scons_platform'] == 'x86-32':
+ # TODO(mseaborn): Enable more tests here when they pass.
+ SCons(context, parallel=True, mode=irt_mode,
+ args=flags_run + ['nonsfi_nacl=1', 'run_hello_world_test_irt'])
+
def Main():
context = BuildContext()
« no previous file with comments | « SConstruct ('k') | buildbot/buildbot_pnacl.sh » ('j') | buildbot/buildbot_pnacl.sh » ('J')

Powered by Google App Engine
This is Rietveld 408576698