chrome/browser/safe_browsing/download_protection_service.cc - Issue 2696973002: Allow Safe Browsing backend to select downloads to upload.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/safe_browsing/download_protection_service.cc

Issue 2696973002: Allow Safe Browsing backend to select downloads to upload. (Closed)

Patch Set: Switch histogram to use enum, per isherman Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/safe_browsing/download_protection_service.cc

diff --git a/chrome/browser/safe_browsing/download_protection_service.cc b/chrome/browser/safe_browsing/download_protection_service.cc

index 2b9a6d289d6a85fcaf530010521797147c2c8d78..486af67b8883d6a08a51e1ce0dee72089bad7c18 100644

--- a/chrome/browser/safe_browsing/download_protection_service.cc

+++ b/chrome/browser/safe_browsing/download_protection_service.cc

@@ -597,8 +597,9 @@ class DownloadProtectionService::CheckClientDownloadRequest

if (!token.empty())

SetDownloadPingToken(item_, token);

+ bool upload_requested = response.upload();

DownloadFeedbackService::MaybeStorePingsForDownload(

- result, item_, client_download_request_data_, data);

+ result, upload_requested, item_, client_download_request_data_, data);

}

// We don't need the fetcher anymore.

fetcher_.reset();