tools/metrics/histograms/histograms.xml - Issue 2696973002: Allow Safe Browsing backend to select downloads to upload.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/metrics/histograms/histograms.xml

Side-by-side diff isn't available for this file because of its large size.

Issue 2696973002: Allow Safe Browsing backend to select downloads to upload. (Closed)

Patch Set: Fix up comments Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: tools/metrics/histograms/histograms.xml

diff --git a/tools/metrics/histograms/histograms.xml b/tools/metrics/histograms/histograms.xml

index a48b639be0332459b01b6c1aa2dfa29ed3bab85a..9997f762751084f8a4869d9b29ae08160552a86d 100644

--- a/tools/metrics/histograms/histograms.xml

+++ b/tools/metrics/histograms/histograms.xml

@@ -58444,6 +58444,15 @@ http://cs/file:chrome/histograms.xml - but prefer this file for new entries.

</summary>

</histogram>

+<histogram name="SBDownloadFeedback.UploadRequestedByServer" units="boolean">

Ilya Sherman 2017/02/18 00:31:55 Please use an enum, with labels specific to this h

Nathan Parker 2017/02/18 00:59:59 Done.

+ <owner>nparker@chromium.org</owner>

+ <summary>

+ Records how many non-SAFE files were picked for upload by the server.

Ilya Sherman 2017/02/18 00:31:55 I'd write this as: "For each non-SAFE file, record

Nathan Parker 2017/02/18 00:59:59 Done.

+ Logged before checking the file size, so it may be dropped there.

+ </summary>

+</histogram>

<histogram name="SBDownloadFeedback.UploadResult"

enum="SBDownloadFeedbackUploadResult">

<owner>mattm@chromium.org</owner>

« no previous file with comments | « chrome/common/safe_browsing/csd.proto ('k') | no next file » | no next file with comments »