Allow Safe Browsing backend to select downloads to upload.

chrome/browser/safe_browsing/download_feedback_service.h

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_SAFE_BROWSING_DOWNLOAD_FEEDBACK_SERVICE_H_
 #define CHROME_BROWSER_SAFE_BROWSING_DOWNLOAD_FEEDBACK_SERVICE_H_
 
 #include <memory>
 #include <queue>
 #include <string>
@@ skipping 25 matching lines @@
 // Lives on the UI thread.
 class DownloadFeedbackService {
  public:
   DownloadFeedbackService(net::URLRequestContextGetter* request_context_getter,
                           base::TaskRunner* file_task_runner);
   ~DownloadFeedbackService();
 
   // Stores the request and response ping data from the download check, if the
   // check result and file size are eligible. This must be called after a
   // download has been flagged as malicious in order for the download to be
-  // enabled for uploading.
+  // enabled for uploading. Some "unknown" verdict files can be marked for
+  // upload by the server with |upload_requested| if it's needed for better

[Jialiu Lin, 2017/02/15 00:45:27]

nit: Do we need to mention "Unknown" verdict in the comment? This code does not
check whether the verdict is "unknown" or not. 

[Nathan Parker, 2017/02/15 01:38:04]

good point.  The plan is that the backend will only use this w/ unknown
verdicts, but I'm not enforcing it in the code.  Fixed the comment.

+  // classification.
   static void MaybeStorePingsForDownload(
       DownloadProtectionService::DownloadCheckResult result,
+      bool upload_requested,
       content::DownloadItem* download,
       const std::string& ping,
       const std::string& response);
 
   // Test if pings have been stored for |download|.
   static bool IsEnabledForDownload(const content::DownloadItem& download);
 
   // Get the ping values stored in |download|. Returns false if no ping values
   // are present.
   static bool GetPingsForDownloadForTesting(
@@ skipping 31 matching lines @@
   // items are pending.
   std::queue<std::unique_ptr<DownloadFeedback>> active_feedback_;
 
   base::WeakPtrFactory<DownloadFeedbackService> weak_ptr_factory_;
 
   DISALLOW_COPY_AND_ASSIGN(DownloadFeedbackService);
 };
 }  // namespace safe_browsing
 
 #endif  // CHROME_BROWSER_SAFE_BROWSING_DOWNLOAD_FEEDBACK_SERVICE_H_