Move common cr-policy-indicator behavior into CrPolicyIndicatorBehavior

chrome/browser/resources/settings/controls/controlled_button.html

Index: chrome/browser/resources/settings/controls/controlled_button.html
diff --git a/chrome/browser/resources/settings/controls/controlled_button.html b/chrome/browser/resources/settings/controls/controlled_button.html
index 7f4e69d4bded78e4317fee1dea523a7e3220b356..b053b26607754bdc21f21c2f85035fd2bd6dde2e 100644
--- a/chrome/browser/resources/settings/controls/controlled_button.html
+++ b/chrome/browser/resources/settings/controls/controlled_button.html
@@ -1,7 +1,6 @@
 <link rel="import" href="chrome://resources/html/assert.html">
 <link rel="import" href="chrome://resources/html/polymer.html">
 <link rel="import" href="chrome://resources/polymer/v1_0/paper-button/paper-button.html">
-<link rel="import" href="chrome://resources/cr_elements/policy/cr_policy_indicator_behavior.html">
 <link rel="import" href="chrome://resources/cr_elements/policy/cr_policy_pref_behavior.html">
 <link rel="import" href="chrome://resources/cr_elements/policy/cr_policy_pref_indicator.html">
 <link rel="import" href="pref_control_behavior.html">
@@ -43,7 +42,7 @@
       <content></content>
     </paper-button>
 
-    <template is="dom-if" if="[[showIndicator_(pref)]]" restamp>
+    <template is="dom-if" if="[[hasPrefPolicyIndicator(pref.*)]]" restamp>

[dschuyler, 2017/02/28 19:42:40]

Let's make this more general by dropping the "Policy" part, e.g.
hasPrefIndicator or hasControlledIndicator. 

[stevenjb, 2017/02/28 20:04:37]

May I suggest that if we do any significant renaming we do it in a separate CL
once the current in-progress CLs have landed? 

Currently the indicators are in a "policy" directory and are all prefixed with
cr-policy. Using "policy" to also describe indicators that may come form an
extension may not be ideal, but if we decide to drop "policy" we should do so
consistently and in an isolated CL.

For now, this name is at least consistent with the existing
"isPrefPolicyControlled" in the same behavior.

[michaelpg, 2017/02/28 21:55:49]

Acknowledged.

       <cr-policy-pref-indicator pref="[[pref]]" on-tap="onIndicatorTap_">
       </cr-policy-pref-indicator>
     </template>