ui/webui/resources/cr_elements/policy/README.md - Issue 2696903005: Move common cr-policy-indicator behavior into CrPolicyIndicatorBehavior

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: ui/webui/resources/cr_elements/policy/README.md

Issue 2696903005: Move common cr-policy-indicator behavior into CrPolicyIndicatorBehavior (Closed)

Patch Set: TODO and README update Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
(Empty)
	1 # Policy indicators

	2

	3 Setting that can't be controlled by the current user often show an icon and a
	dschuyler 2017/02/28 22:16:33 maybe s/Setting/Settings/ or s/Setting/A setting maybe s/Setting/Settings/ or s/Setting/A setting/ michaelpg 2017/03/01 00:34:00 Done. Show quoted text On 2017/02/28 22:16:33, dschuyler wrote: > maybe > s/Setting/Settings/ > > or > s/Setting/A setting/ Done.
	4 tooltip explaining why. This happens when a setting is:

	5

	6 * enforced by user policy, or different from a policy's "recommended" value

	7 * overridden by an extension

	8 * or (on Chrome OS):

	9 * enforced/recommended by device policy (for enrolled devices)

	10 * set by the device owner (for non-enrolled devices)

	11 * controlled by the primary user (for multiple profile sessions)

	12

	13 ## Indicator UI

	14

	15 The badge icons are sourced from [cr_elements/icons.html] by default.

	16

	17 Indicators show a tooltip with explanatory text on hover, assuming

	18 `CrPolicyStrings` is defined.
	dschuyler 2017/02/28 22:16:33 maybe s/assuming/assuming an entry in/ (since CrPo maybe s/assuming/assuming an entry in/ (since CrPolicyStrings will be defined unconditionally iiuc). michaelpg 2017/03/01 00:34:00 No, the actual object needs to be defined -- we do Show quoted text On 2017/02/28 22:16:33, dschuyler wrote: > maybe s/assuming/assuming an entry in/ > (since CrPolicyStrings will be defined unconditionally iiuc). No, the actual object needs to be defined -- we do this in settings_ui.js and some tests. If it's not defined we just don't display tooltips. I think OOBE is like that.
	19

	20 ## Using an indicator

	21

	22 Elements like `<cr-policy-pref-indicator>` and `<cr-policy-network-indicator>`

	23 are provided to be reused in WebUI pages:

	24

	25 <cr-policy-pref-indicator pref="[[pref]]"></cr-policy-pref-indicator>

	26

	27 Example: [settings-checkbox].

	28

	29 For one-off or composed elements, `CrPolicyIndicatorBehavior` provides some

	30 configurable properties and calculates dependent properties, such as the

	31 tooltip, icon, and visibility of the indicator.

	32

	33 Example: [cr_policy_pref_indicator.js] overrides `indicatorType` and

	34 `indicatorTooltip`; [cr_policy_pref_indicator.html] displays the computed

	35 properties from `CrPolicyIndicatorBehavior`.

	36

	37

	38 [cr_elements/icons.html]: ../icons.html

	39 [settings-checkbox]: /chrome/browser/resources/settings/controls/settings_checkb ox.html

	40 [cr_policy_pref_indicator.js]: cr_policy_pref_indicator.js

	41 [cr_policy_pref_indicator.html]: cr_policy_pref_indicator.html

OLD	NEW