ui/webui/resources/cr_elements/policy/README.md - Issue 2696903005: Move common cr-policy-indicator behavior into CrPolicyIndicatorBehavior

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: ui/webui/resources/cr_elements/policy/README.md

Issue 2696903005: Move common cr-policy-indicator behavior into CrPolicyIndicatorBehavior (Closed)

Patch Set: rename hasPolicy Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« chrome/browser/resources/settings/controls/controlled_button.html ('K') | « chrome/test/data/webui/settings/date_time_page_tests.js ('k') | ui/webui/resources/cr_elements/policy/compiled_resources2.gyp » ('j') | ui/webui/resources/cr_elements/policy/cr_policy_pref_behavior.js » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 Policy indicators show when a setting is controlled by something other than the

	2 user, especially user/device policy. The badge icons are sourced from

	3 [cr_elements/icons.html](../icons.html) by default. Indicators show a tooltip on

	4 hover when `CrPolicyStrings` is defined.

	5

	6 Elements like `<cr-policy-pref-indicator>` and `<cr-policy-network-indicator>`

	7 are designed to be reused in WebUI pages:

	8

	9 <cr-policy-pref-indicator pref="[[pref]]"></cr-policy-pref-indicator>

	10

	11 For one-off or composed elements, CrPolicyIndicatorBehavior provides some

	12 configurable properties and calculates dependent properties, such as the

	13 tooltip, icon, and visibility of the indicator.
	dschuyler 2017/02/28 20:09:29 Just a suggestion, totally optional: The above is Just a suggestion, totally optional: The above is a good overview of the features of this code, which is cool. To add to it, I'd find it super useful to have a list of instructions and/or and example to search for. e.g. "To add a new indicator: 1. 2." or "For an example of a correctly implemented indicator, search the code for ______." michaelpg 2017/02/28 21:55:50 Were you looking for instructions on creating a ne Show quoted text On 2017/02/28 20:09:29, dschuyler wrote: > Just a suggestion, totally optional: > The above is a good overview of the features of this code, which is cool. To add > to it, I'd find it super useful to have a list of instructions and/or and > example to search for. e.g. > > "To add a new indicator: > 1. > 2." > > or > > "For an example of a correctly implemented indicator, search the code for > ______." > Were you looking for instructions on creating a new indicator in policy/, or for displaying a policy/ indicator elsewhere in the UI? I've expanded the README a bit for clarity, LMK where it can be improved.
OLD	NEW