Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(612)

Unified Diff: media/blink/webmediaplayer_impl.cc

Issue 2696893002: [Blink>Media] Add heuristic for dominant video detection for Android (Closed)
Patch Set: addressed nits Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: media/blink/webmediaplayer_impl.cc
diff --git a/media/blink/webmediaplayer_impl.cc b/media/blink/webmediaplayer_impl.cc
index d604641bad5ae1f2a6fcedae673dd6004ab5141a..184eee10b98ebb0efd8ce3fda9a155bae002b65e 100644
--- a/media/blink/webmediaplayer_impl.cc
+++ b/media/blink/webmediaplayer_impl.cc
@@ -365,7 +365,6 @@ void WebMediaPlayerImpl::enteredFullscreen() {
}
if (observer_)
observer_->OnEnteredFullscreen();
- delegate_->SetIsEffectivelyFullscreen(delegate_id_, true);
}
void WebMediaPlayerImpl::exitedFullscreen() {
@@ -375,7 +374,6 @@ void WebMediaPlayerImpl::exitedFullscreen() {
DisableOverlay();
if (observer_)
observer_->OnExitedFullscreen();
- delegate_->SetIsEffectivelyFullscreen(delegate_id_, false);
}
void WebMediaPlayerImpl::becameDominantVisibleContent(bool isDominant) {
@@ -383,6 +381,11 @@ void WebMediaPlayerImpl::becameDominantVisibleContent(bool isDominant) {
observer_->OnBecameDominantVisibleContent(isDominant);
}
+void WebMediaPlayerImpl::setIsEffectivelyFullscreen(
+ bool isEffectivelyFullscreen) {
+ delegate_->SetIsEffectivelyFullscreen(delegate_id_, isEffectivelyFullscreen);
+}
+
void WebMediaPlayerImpl::DoLoad(LoadType load_type,
const blink::WebURL& url,
CORSMode cors_mode) {

Powered by Google App Engine
This is Rietveld 408576698