Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(532)

Unified Diff: third_party/WebKit/public/platform/WebMediaPlayer.h

Issue 2696893002: [Blink>Media] Add heuristic for dominant video detection for Android (Closed)
Patch Set: fixing logic in WMPI Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/public/platform/WebMediaPlayer.h
diff --git a/third_party/WebKit/public/platform/WebMediaPlayer.h b/third_party/WebKit/public/platform/WebMediaPlayer.h
index dd88518fb0a277a27ae0762c2e3c46d9364c81f4..c18baf7f4e57e4aa95cbcd3d47ccf2a5d39809a4 100644
--- a/third_party/WebKit/public/platform/WebMediaPlayer.h
+++ b/third_party/WebKit/public/platform/WebMediaPlayer.h
@@ -272,6 +272,11 @@ class WebMediaPlayer {
// WebMediaPlayerClient::activateViewportIntersectionMonitoring().
virtual void becameDominantVisibleContent(bool isDominant) {}
miu 2017/02/24 22:44:39 Can the old heuristic be removed? It seems the new
Zhiqiang Zhang (Slow) 2017/02/25 18:48:27 Filed a bug and added TODO :)
+ // Inform WebMediaPlayer when the element starts/stops being the effectively
+ // fullscreen video, i.e. being the fullscreen element or child of the
+ // fullscreen element, and being dominant in the viewport.
+ virtual void setIsEffectivelyFullscreen(bool) {}
+
virtual void enabledAudioTracksChanged(
const WebVector<TrackId>& enabledTrackIds) {}
// |selectedTrackId| is null if no track is selected.

Powered by Google App Engine
This is Rietveld 408576698