Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(81)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: third_party/WebKit/public/platform/WebMediaPlayer.h

Issue 2696893002: [Blink>Media] Add heuristic for dominant video detection for Android (Closed)
Patch Set: addressed mlamouri's comments Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« third_party/WebKit/Source/core/html/MediaCustomControlsFullscreenDetector.cpp ('K') | « third_party/WebKit/Source/core/html/MediaCustomControlsFullscreenDetectorTest.cpp ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/public/platform/WebMediaPlayer.h
diff --git a/third_party/WebKit/public/platform/WebMediaPlayer.h b/third_party/WebKit/public/platform/WebMediaPlayer.h
index dd88518fb0a277a27ae0762c2e3c46d9364c81f4..e00af5d95287d94e80dc0e9a4fde9aea73259bfe 100644
--- a/third_party/WebKit/public/platform/WebMediaPlayer.h
+++ b/third_party/WebKit/public/platform/WebMediaPlayer.h
@@ -272,6 +272,11 @@ class WebMediaPlayer {
// WebMediaPlayerClient::activateViewportIntersectionMonitoring().
virtual void becameDominantVisibleContent(bool isDominant) {}
+ // Inform WebMediaPlayer when the element starts/stops being the effectively
+ // fullscreen video, i.e. being fullscreened or in a fullscreened node, and
xjz 2017/02/22 18:48:34 s/in a fullscreened node/in a fullscreened documen
Zhiqiang Zhang (Slow) 2017/02/23 21:50:55 Done.
+ // being the dominant video in fullscreen.
+ virtual void setEffectivelyFullscreen(bool isEffectivelyFullscreen) {}
+
virtual void enabledAudioTracksChanged(
const WebVector<TrackId>& enabledTrackIds) {}
// |selectedTrackId| is null if no track is selected.
« third_party/WebKit/Source/core/html/MediaCustomControlsFullscreenDetector.cpp ('K') | « third_party/WebKit/Source/core/html/MediaCustomControlsFullscreenDetectorTest.cpp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698