third_party/WebKit/public/platform/WebMediaPlayer.h - Issue 2696893002: [Blink>Media] Add heuristic for dominant video detection for Android

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/public/platform/WebMediaPlayer.h

Issue 2696893002: [Blink>Media] Add heuristic for dominant video detection for Android (Closed)

Patch Set: s/CustomControlsFullscreenDetector/MediaCustomControlsFullscreenDetector Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/public/platform/WebMediaPlayer.h

diff --git a/third_party/WebKit/public/platform/WebMediaPlayer.h b/third_party/WebKit/public/platform/WebMediaPlayer.h

index dd88518fb0a277a27ae0762c2e3c46d9364c81f4..b268556f8e4880987dd96d9193fa7c12628564ba 100644

--- a/third_party/WebKit/public/platform/WebMediaPlayer.h

+++ b/third_party/WebKit/public/platform/WebMediaPlayer.h

@@ -272,6 +272,8 @@ class WebMediaPlayer {

// WebMediaPlayerClient::activateViewportIntersectionMonitoring().

virtual void becameDominantVisibleContent(bool isDominant) {}

+ virtual void becameDominantVisibleContentInFullscreen(bool isDominant) {}

mlamouri (slow - plz ping) 2017/02/21 21:58:28 I would call this `setEffectivelyFullscreen` but i

Zhiqiang Zhang (Slow) 2017/02/22 12:29:18 Done.

virtual void enabledAudioTracksChanged(

const WebVector<TrackId>& enabledTrackIds) {}

// |selectedTrackId| is null if no track is selected.