[Blink>Media] Add heuristic for dominant video detection for Android

third_party/WebKit/Source/core/html/MediaCustomControlsFullscreenDetector.h

+// Copyright 2017 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef MediaCustomControlsFullscreenDetector_h
+#define MediaCustomControlsFullscreenDetector_h
+
+#include "core/CoreExport.h"
+#include "core/events/EventListener.h"
+#include "platform/Timer.h"
+
+namespace blink {
+
+class Document;
+class HTMLVideoElement;
+class IntRect;
+class TimerBase;
+
+class CORE_EXPORT MediaCustomControlsFullscreenDetector final
+    : public EventListener {
+ public:

[mlamouri (slow - plz ping), 2017/02/27 18:04:55]

Add WTF_MAKE_NONCOPYABLE() above `public:`?

[Zhiqiang Zhang (Slow), 2017/02/28 12:16:52]

Done.

+  explicit MediaCustomControlsFullscreenDetector(HTMLVideoElement&);
+
+  // EventListener implementation.
+  bool operator==(const EventListener&) const override;
+
+  HTMLVideoElement& videoElement() { return *m_videoElement; }

[mlamouri (slow - plz ping), 2017/02/27 18:04:55]

could this be private?

[Zhiqiang Zhang (Slow), 2017/02/28 12:16:52]

Done.

+
+  void didMoveToNewDocument(Document& oldDocument);
+
+  DECLARE_VIRTUAL_TRACE();
+
+ private:
+  friend class MediaCustomControlsFullscreenDetectorTest;
+
+  // EventListener implementation.
+  void handleEvent(ExecutionContext*, Event*) override;
+
+  bool onEnterFullscreen();
+  bool onExitFullscreen();

[mlamouri (slow - plz ping), 2017/02/27 18:04:55]

these are not implemented it looks like

[Zhiqiang Zhang (Slow), 2017/02/28 12:16:52]

Removed.

+
+  void onCheckViewportIntersectionTimerFired(TimerBase*);
+
+  bool isVideoOrParentFullscreen();
+
+  static bool computeIsDominantVideo(const IntRect& targetRect,

[mlamouri (slow - plz ping), 2017/02/27 18:04:55]

Maybe leave a note that this is visible for tests? You could even have
"computeIsDominantVideoForTests()" that call an anonymous function inside the
cpp file if we want very nit-picky :)

[Zhiqiang Zhang (Slow), 2017/02/28 12:16:52]

Using name `computeIsDominantVideoForTests()`. Calling an anonymous function
seems a bit overkill.

+                                     const IntRect& rootRect,
+                                     const IntRect& intersectionRect);
+
+  // `m_videoElement` owns |this|.
+  Member<HTMLVideoElement> m_videoElement;
+  TaskRunnerTimer<MediaCustomControlsFullscreenDetector>
+      m_checkViewportIntersectionTimer;
+};
+
+}  // namespace blink
+
+#endif  // MediaCustomControlsFullscreenDetector_h