pkg/analysis_server/lib/src/plugin/result_merger.dart - Issue 2696853002: Extract object creation methods for use by a future test class

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: pkg/analysis_server/lib/src/plugin/result_merger.dart

Issue 2696853002: Extract object creation methods for use by a future test class (Closed)

Patch Set: Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: pkg/analysis_server/lib/src/plugin/result_merger.dart

diff --git a/pkg/analysis_server/lib/src/plugin/result_merger.dart b/pkg/analysis_server/lib/src/plugin/result_merger.dart

index b9c28c17ffd72aa519d7da361d310435822255bd..b76656d1151ba0598c16c29985803e8efbd1363f 100644

--- a/pkg/analysis_server/lib/src/plugin/result_merger.dart

+++ b/pkg/analysis_server/lib/src/plugin/result_merger.dart

@@ -487,7 +487,7 @@ class ResultMerger {

bool isCopied = copiedOutline != null;

copiedOutline ??= outline;

List<Outline> currentChildren = copiedOutline.children;

- if (currentChildren.isEmpty) {

+ if (currentChildren == null || currentChildren.isEmpty) {

return outline;

}

List<Outline> updatedChildren =