Issue 2696853002: Extract object creation methods for use by a future test class

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2696853002: Extract object creation methods for use by a future test class (Closed)

Created:
3 years, 10 months ago by Brian Wilkerson

Modified:
3 years, 10 months ago

Reviewers:
scheglov

CC:
reviews_dartlang.org

Target Ref:
refs/heads/master

Visibility:
Public.

Created: 3 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+372 lines, -152 lines)			Patch
M	pkg/analysis_server/lib/src/plugin/result_collector.dart	View	6 chunks	+26 lines, -4 lines	0 comments	Download
M	pkg/analysis_server/lib/src/plugin/result_merger.dart	View	1 chunk	+1 line, -1 line	0 comments	Download
A	pkg/analysis_server/test/src/plugin/protocol_test_utilities.dart	View	1 chunk	+304 lines, -0 lines	0 comments	Download
M	pkg/analysis_server/test/src/plugin/result_converter_test.dart	View	9 chunks	+41 lines, -143 lines	0 comments	Download
M	pkg/analysis_server/test/src/plugin/result_merger_test.dart	View	1 chunk	+0 lines, -4 lines	0 comments	Download

Total messages: 5 (2 generated)

Brian Wilkerson

This also adds some utility to ResultCollector and contains some code clean-up.

3 years, 10 months ago (2017-02-14 19:49:00 UTC) #2

Brian Wilkerson

3 years, 10 months ago (2017-02-14 20:37:17 UTC) #5

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
a56cee72e5349caf1844b8d656e6df5728083db5 (presubmit successful).