Issue 26968006: detach blur result texture when it is the same texture used to render path mask

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 26968006: detach blur result texture when it is the same texture used to render path mask (Closed)

Created:
7 years, 2 months ago by bsalomon

Modified:
7 years, 2 months ago

Reviewers:
robertphillips

CC:
skia-review_googlegroups.com

Base URL:
https://skia.googlecode.com/svn/trunk

Visibility:
Public.

More Reviews

Description

detach blur result texture when it is the same texture used to render path mask Committed: http://code.google.com/p/skia/source/detail?r=11805

Patch Set 3 : fix comment #

Created: 7 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+112 lines, -0 lines)			Patch
A	gm/skbug1719.cpp	View	1 2	1 chunk	+102 lines, -0 lines	0 comments	Download
M	gyp/gmslides.gypi	View	1	1 chunk	+1 line, -0 lines	0 comments	Download
M	src/gpu/SkGpuDevice.cpp	View		1 chunk	+9 lines, -0 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

robertphillips

lgtm + 1 nit https://codereview.chromium.org/26968006/diff/4001/gm/skbug1719.cpp File gm/skbug1719.cpp (right): https://codereview.chromium.org/26968006/diff/4001/gm/skbug1719.cpp#newcode14 gm/skbug1719.cpp:14: /** tests -> test

7 years, 2 months ago (2013-10-16 01:50:45 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/bsalomon@google.com/26968006/9001

7 years, 2 months ago (2013-10-16 13:14:08 UTC) #4

Message was sent while issue was closed.

Change committed as 11805

Expand Messages | Collapse Messages

Issue 26968006: detach blur result texture when it is the same texture used to render path mask (Closed)

Description

Patch Set 1 #

Patch Set 2 : Add GM #

Patch Set 3 : fix comment #

Messages