Issue 26968003: Remove DirectoryException and LinkException from dart:io and use FileException instaed.

Issue 26968003: Remove DirectoryException and LinkException from dart:io and use FileException instaed. (Closed)

Created:
7 years, 2 months ago by Anders Johnsen

Modified:
7 years, 2 months ago

Reviewers:
Bob Nystrom, Søren Gjesse, floitsch, nweiz

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Remove FileException, DirectoryException and LinkException from dart:io and use FileSystemException instaed. BUG=https://code.google.com/p/dart/issues/detail?id=12461 R=nweiz@google.com, sgjesse@google.com Committed: https://code.google.com/p/dart/source/detail?r=29168

Patch Set 1 #

Patch Set 2 : Rename FileException to FileSystemException. #

Patch Set 3 : Merge with master. #

Created: 7 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+191 lines, -251 lines)			Patch
M	pkg/watcher/lib/src/utils.dart	View	1	1 chunk	+3 lines, -2 lines	0 comments	Download
M	runtime/bin/directory.cc	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	runtime/bin/file_patch.dart	View	1 2	2 chunks	+2 lines, -2 lines	0 comments	Download
M	runtime/bin/stdio_patch.dart	View	1	2 chunks	+3 lines, -3 lines	0 comments	Download
M	sdk/lib/_internal/compiler/implementation/source_file_provider.dart	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	sdk/lib/_internal/dartdoc/lib/dartdoc.dart	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	sdk/lib/_internal/dartdoc/lib/src/export_map.dart	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	sdk/lib/_internal/pub/lib/src/barback/server.dart	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	sdk/lib/_internal/pub/lib/src/io.dart	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	sdk/lib/_internal/pub/lib/src/utils.dart	View	1	2 chunks	+3 lines, -6 lines	0 comments	Download
M	sdk/lib/io/common.dart	View	1	1 chunk	+2 lines, -2 lines	0 comments	Download
M	sdk/lib/io/directory.dart	View	1	1 chunk	+0 lines, -29 lines	0 comments	Download
M	sdk/lib/io/directory_impl.dart	View	1 2	10 chunks	+11 lines, -11 lines	0 comments	Download
M	sdk/lib/io/file.dart	View	1 2	23 chunks	+27 lines, -27 lines	0 comments	Download
M	sdk/lib/io/file_impl.dart	View	1 2	19 chunks	+21 lines, -21 lines	0 comments	Download
M	sdk/lib/io/file_system_entity.dart	View	1 2	3 chunks	+3 lines, -3 lines	0 comments	Download
M	sdk/lib/io/link.dart	View	1	5 chunks	+5 lines, -34 lines	0 comments	Download
M	tests/standalone/io/async_catch_errors_test.dart	View	1	2 chunks	+5 lines, -5 lines	0 comments	Download
M	tests/standalone/io/directory_chdir_test.dart	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	tests/standalone/io/directory_error_test.dart	View	1	9 chunks	+28 lines, -28 lines	0 comments	Download
M	tests/standalone/io/directory_list_nonexistent_test.dart	View	1	2 chunks	+4 lines, -4 lines	0 comments	Download
M	tests/standalone/io/directory_test.dart	View	1	7 chunks	+7 lines, -7 lines	0 comments	Download
M	tests/standalone/io/file_error_test.dart	View	1	17 chunks	+41 lines, -41 lines	0 comments	Download
M	tests/standalone/io/file_read_encoded_test.dart	View	1	4 chunks	+4 lines, -4 lines	0 comments	Download
M	tests/standalone/io/file_test.dart	View	1 2	12 chunks	+14 lines, -14 lines	0 comments	Download
M	tests/standalone/io/link_test.dart	View	1	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

Anders Johnsen

Bob, Nathan, please check pub/pkg changes. Sgjesse, please check IO changes. Florian, mainly FYI. See ...

7 years, 2 months ago (2013-10-11 10:34:55 UTC) #1

Anders Johnsen

PTAL, renamed FileException to FileSystemException.

7 years, 2 months ago (2013-10-21 12:40:40 UTC) #4

Anders Johnsen

7 years, 2 months ago (2013-10-24 12:17:44 UTC) #6

Message was sent while issue was closed.

Committed patchset #3 manually as r29168 (presubmit successful).

Expand Messages | Collapse Messages