Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(23)

Issue 2696783002: Properly resolve upper bounds of generic function's type parameters. (Closed)

Created:
3 years, 10 months ago by regis
Modified:
3 years, 10 months ago
Reviewers:
hausner
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Properly resolve upper bounds of generic function's type parameters. Various minor cleanup related to generic functions. Add flag in preparation of future work to fully support generic methods. R=hausner@google.com Committed: https://github.com/dart-lang/sdk/commit/2037e7e88468ceb286f184b469a7781061c4e4f5

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+108 lines, -37 lines) Patch
M runtime/vm/class_finalizer.cc View 4 chunks +35 lines, -8 lines 0 comments Download
M runtime/vm/kernel_reader.cc View 1 chunk +1 line, -1 line 0 comments Download
M runtime/vm/object.h View 3 chunks +5 lines, -1 line 0 comments Download
M runtime/vm/object.cc View 7 chunks +22 lines, -6 lines 0 comments Download
M runtime/vm/parser.cc View 7 chunks +45 lines, -21 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
regis
3 years, 10 months ago (2017-02-14 09:01:39 UTC) #2
hausner
LGTM.
3 years, 10 months ago (2017-02-14 09:39:58 UTC) #3
regis
3 years, 10 months ago (2017-02-14 09:50:13 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
2037e7e88468ceb286f184b469a7781061c4e4f5 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698