Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(78)

Side by Side Diff: PRESUBMIT.py

Issue 269673005: media: Add MediaOzonePlatform support (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 # Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 # Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 """Top-level presubmit script for Chromium. 5 """Top-level presubmit script for Chromium.
6 6
7 See http://dev.chromium.org/developers/how-tos/depottools/presubmit-scripts 7 See http://dev.chromium.org/developers/how-tos/depottools/presubmit-scripts
8 for more details about the presubmit API built into gcl. 8 for more details about the presubmit API built into gcl.
9 """ 9 """
10 10
(...skipping 1075 matching lines...) Expand 10 before | Expand all | Expand 10 after
1086 results.extend(_CheckAuthorizedAuthor(input_api, output_api)) 1086 results.extend(_CheckAuthorizedAuthor(input_api, output_api))
1087 results.extend( 1087 results.extend(
1088 _CheckNoProductionCodeUsingTestOnlyFunctions(input_api, output_api)) 1088 _CheckNoProductionCodeUsingTestOnlyFunctions(input_api, output_api))
1089 results.extend(_CheckNoIOStreamInHeaders(input_api, output_api)) 1089 results.extend(_CheckNoIOStreamInHeaders(input_api, output_api))
1090 results.extend(_CheckNoUNIT_TESTInSourceFiles(input_api, output_api)) 1090 results.extend(_CheckNoUNIT_TESTInSourceFiles(input_api, output_api))
1091 results.extend(_CheckNoNewWStrings(input_api, output_api)) 1091 results.extend(_CheckNoNewWStrings(input_api, output_api))
1092 results.extend(_CheckNoDEPSGIT(input_api, output_api)) 1092 results.extend(_CheckNoDEPSGIT(input_api, output_api))
1093 results.extend(_CheckNoBannedFunctions(input_api, output_api)) 1093 results.extend(_CheckNoBannedFunctions(input_api, output_api))
1094 results.extend(_CheckNoPragmaOnce(input_api, output_api)) 1094 results.extend(_CheckNoPragmaOnce(input_api, output_api))
1095 results.extend(_CheckNoTrinaryTrueFalse(input_api, output_api)) 1095 results.extend(_CheckNoTrinaryTrueFalse(input_api, output_api))
1096 results.extend(_CheckUnwantedDependencies(input_api, output_api)) 1096 # HACK
1097 # ** Presubmit ERRORS **
1098 # You added one or more #includes that violate checkdeps rules.
1099 # ui/ozone/ozone_platform.cc
1100 # Illegal include: "content/common/gpu/media/video_decode_factory_ozone.h"
1101 # Because of no rule applying. \
1102 # ui/ozone/platform/dri/ozone_platform_dri.cc
1103 # Illegal include: "content/common/gpu/media/video_decode_factory_ozone.h"
1104 # Because of no rule applying. \
1105 # ui/ozone/platform/test/ozone_platform_test.cc
1106 # Illegal include: "content/common/gpu/media/video_decode_factory_ozone.h"
1107 # Because of no rule applying.
1108 # results.extend(_CheckUnwantedDependencies(input_api, output_api))
1097 results.extend(_CheckFilePermissions(input_api, output_api)) 1109 results.extend(_CheckFilePermissions(input_api, output_api))
1098 results.extend(_CheckNoAuraWindowPropertyHInHeaders(input_api, output_api)) 1110 results.extend(_CheckNoAuraWindowPropertyHInHeaders(input_api, output_api))
1099 results.extend(_CheckIncludeOrder(input_api, output_api)) 1111 results.extend(_CheckIncludeOrder(input_api, output_api))
1100 results.extend(_CheckForVersionControlConflicts(input_api, output_api)) 1112 results.extend(_CheckForVersionControlConflicts(input_api, output_api))
1101 results.extend(_CheckPatchFiles(input_api, output_api)) 1113 results.extend(_CheckPatchFiles(input_api, output_api))
1102 results.extend(_CheckHardcodedGoogleHostsInLowerLayers(input_api, output_api)) 1114 results.extend(_CheckHardcodedGoogleHostsInLowerLayers(input_api, output_api))
1103 results.extend(_CheckNoAbbreviationInPngFileName(input_api, output_api)) 1115 results.extend(_CheckNoAbbreviationInPngFileName(input_api, output_api))
1104 results.extend(_CheckForInvalidOSMacros(input_api, output_api)) 1116 results.extend(_CheckForInvalidOSMacros(input_api, output_api))
1105 results.extend(_CheckAddedDepsHaveTargetApprovals(input_api, output_api)) 1117 results.extend(_CheckAddedDepsHaveTargetApprovals(input_api, output_api))
1106 results.extend( 1118 results.extend(
(...skipping 390 matching lines...) Expand 10 before | Expand all | Expand 10 after
1497 builders.extend(['cros_x86']) 1509 builders.extend(['cros_x86'])
1498 1510
1499 # The AOSP bot doesn't build the chrome/ layer, so ignore any changes to it 1511 # The AOSP bot doesn't build the chrome/ layer, so ignore any changes to it
1500 # unless they're .gyp(i) files as changes to those files can break the gyp 1512 # unless they're .gyp(i) files as changes to those files can break the gyp
1501 # step on that bot. 1513 # step on that bot.
1502 if (not all(re.search('^chrome', f) for f in files) or 1514 if (not all(re.search('^chrome', f) for f in files) or
1503 any(re.search('\.gypi?$', f) for f in files)): 1515 any(re.search('\.gypi?$', f) for f in files)):
1504 builders.extend(['android_aosp']) 1516 builders.extend(['android_aosp'])
1505 1517
1506 return GetDefaultTryConfigs(builders) 1518 return GetDefaultTryConfigs(builders)
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698