tools/clang/blink_gc_plugin/tests/legacy_naming/static_singleton.txt - Issue 2696713003: blink_gc_plugin: detect singletons with embedded ScriptWrappables.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: tools/clang/blink_gc_plugin/tests/legacy_naming/static_singleton.txt

Issue 2696713003: blink_gc_plugin: detect singletons with embedded ScriptWrappables.

Patch Set: non-copying iteration Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « tools/clang/blink_gc_plugin/tests/legacy_naming/static_singleton.flags ('k') | tools/clang/blink_gc_plugin/tests/static_singleton.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 static_singleton.cpp:14:3: warning: [blink-gc] The static singleton 'object' con tains one or more unsafe ScriptWrappable references

	2 DEFINE_STATIC_LOCAL(HeapObject, object);

	3 ^

	4 static_singleton.cpp:8:3: note: expanded from macro 'DEFINE_STATIC_LOCAL'

	5 BLINK_STATIC_SINGLETON() \

	6 ^

	7 ./heap/stubs.h:192:3: note: expanded from macro 'BLINK_STATIC_SINGLETON'

	8 __attribute__((annotate("blink_gc_singleton_type")))

	9 ^

	10 note: [blink-gc] Embedded unsafe ScriptWrappable-derived field with type 'class blink::AScriptWrappable' located at 'b_ => a_'

	11 static_singleton.cpp:22:5: warning: [blink-gc] The static singleton 'object' con tains one or more unsafe ScriptWrappable references

	12 DEFINE_STATIC_LOCAL(HeapObject, object);

	13 ^

	14 static_singleton.cpp:8:3: note: expanded from macro 'DEFINE_STATIC_LOCAL'

	15 BLINK_STATIC_SINGLETON() \

	16 ^

	17 ./heap/stubs.h:192:3: note: expanded from macro 'BLINK_STATIC_SINGLETON'

	18 __attribute__((annotate("blink_gc_singleton_type")))

	19 ^

	20 note: [blink-gc] Embedded unsafe ScriptWrappable-derived field with type 'class blink::AScriptWrappable' located at 'b_ => a_'

	21 static_singleton.cpp:25:3: warning: [blink-gc] The static singleton 'object' con tains one or more unsafe ScriptWrappable references

	22 DEFINE_STATIC_LOCAL(HeapObject, object);

	23 ^

	24 static_singleton.cpp:8:3: note: expanded from macro 'DEFINE_STATIC_LOCAL'

	25 BLINK_STATIC_SINGLETON() \

	26 ^

	27 ./heap/stubs.h:192:3: note: expanded from macro 'BLINK_STATIC_SINGLETON'

	28 __attribute__((annotate("blink_gc_singleton_type")))

	29 ^

	30 note: [blink-gc] Embedded unsafe ScriptWrappable-derived field with type 'class blink::AScriptWrappable' located at 'b_ => a_'

	31 3 warnings generated.

OLD	NEW