third_party/WebKit/Source/wtf/text/AtomicStringTable.cpp - Issue 2696703008: Adds RefPtr::leakRef method to allow raw pointers that prevent destruct.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/wtf/text/AtomicStringTable.cpp

Issue 2696703008: Adds RefPtr::leakRef method to allow raw pointers that prevent destruct. (Closed)

Patch Set: Added deref in RefPtrTest.LeakRef to avoid memory leak. Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/wtf/text/AtomicStringTable.cpp

diff --git a/third_party/WebKit/Source/wtf/text/AtomicStringTable.cpp b/third_party/WebKit/Source/wtf/text/AtomicStringTable.cpp

index bc40b4d64508b2bc236284373b523a2cf0f77d70..2c577689deafc8142913b81db8ac27457bd9641d 100644

--- a/third_party/WebKit/Source/wtf/text/AtomicStringTable.cpp

+++ b/third_party/WebKit/Source/wtf/text/AtomicStringTable.cpp

@@ -137,7 +137,7 @@ struct HashAndUTF8CharactersTranslator {

if (isAllASCII)

newString = StringImpl::create(buffer.characters, buffer.length);

- location = newString.release().leakRef();

+ location = newString.leakRef();

location->setHash(hash);

location->setIsAtomic(true);

}