third_party/WebKit/Source/core/frame/ImageBitmap.cpp - Issue 2696703008: Adds RefPtr::leakRef method to allow raw pointers that prevent destruct.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/frame/ImageBitmap.cpp

Issue 2696703008: Adds RefPtr::leakRef method to allow raw pointers that prevent destruct. (Closed)

Patch Set: Added deref in RefPtrTest.LeakRef to avoid memory leak. Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/frame/ImageBitmap.cpp

diff --git a/third_party/WebKit/Source/core/frame/ImageBitmap.cpp b/third_party/WebKit/Source/core/frame/ImageBitmap.cpp

index 12b14efecf0eceefc15cc2dd1cf68cb7236f3813..1b15e370946db83c88d5055daeca93ffd133e878 100644

--- a/third_party/WebKit/Source/core/frame/ImageBitmap.cpp

+++ b/third_party/WebKit/Source/core/frame/ImageBitmap.cpp

@@ -765,7 +765,7 @@ static sk_sp<SkImage> scaleSkImage(sk_sp<SkImage> skImage,

[](const void*, void* pixels) {

static_cast<Uint8Array*>(pixels)->deref();

- resizedPixels.release().leakRef());

+ resizedPixels.leakRef());

}

RefPtr<Float32Array> resizedPixels =

@@ -778,7 +778,7 @@ static sk_sp<SkImage> scaleSkImage(sk_sp<SkImage> skImage,

[](const void*, void* pixels) {

static_cast<Float32Array*>(pixels)->deref();

- resizedPixels.release().leakRef());

+ resizedPixels.leakRef());

}

ImageBitmap::ImageBitmap(ImageData* data,