Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(18)

Side by Side Diff: third_party/WebKit/Source/wtf/RefPtrTest.cpp

Issue 2696703008: Adds RefPtr::leakRef method to allow raw pointers that prevent destruct. (Closed)
Patch Set: Added deref in RefPtrTest.LeakRef to avoid memory leak. Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "wtf/RefPtr.h" 5 #include "wtf/RefPtr.h"
6 6
7 #include "testing/gtest/include/gtest/gtest.h" 7 #include "testing/gtest/include/gtest/gtest.h"
8 #include "wtf/RefCounted.h" 8 #include "wtf/RefCounted.h"
9 #include "wtf/text/StringImpl.h" 9 #include "wtf/text/StringImpl.h"
10 10
11 namespace WTF { 11 namespace WTF {
12 12
13 TEST(RefPtrTest, Basic) { 13 TEST(RefPtrTest, Basic) {
14 RefPtr<StringImpl> string; 14 RefPtr<StringImpl> string;
15 EXPECT_TRUE(!string); 15 EXPECT_TRUE(!string);
16 string = StringImpl::create("test"); 16 string = StringImpl::create("test");
17 EXPECT_TRUE(!!string); 17 EXPECT_TRUE(!!string);
18 string.clear(); 18 string.clear();
19 EXPECT_TRUE(!string); 19 EXPECT_TRUE(!string);
20 } 20 }
21 21
22 TEST(RefPtrTest, LeakRef) {
23 RefPtr<StringImpl> string = StringImpl::create("test");
24 EXPECT_TRUE(string);
25 EXPECT_TRUE(string->hasOneRef());
26 StringImpl* raw = string.get();
27 StringImpl* leaked = string.leakRef();
28 EXPECT_TRUE(!string);
29 EXPECT_TRUE(leaked);
30 EXPECT_TRUE(leaked->hasOneRef());
31 EXPECT_EQ(raw, leaked);
32 leaked->deref();
Bugs Nash 2017/02/20 01:53:38 Needed to add this line to prevent memory leak whi
33 }
34
22 TEST(RefPtrTest, MoveAssignmentOperator) { 35 TEST(RefPtrTest, MoveAssignmentOperator) {
23 RefPtr<StringImpl> a = StringImpl::create("a"); 36 RefPtr<StringImpl> a = StringImpl::create("a");
24 RefPtr<StringImpl> b = StringImpl::create("b"); 37 RefPtr<StringImpl> b = StringImpl::create("b");
25 b = std::move(a); 38 b = std::move(a);
26 EXPECT_TRUE(!!b); 39 EXPECT_TRUE(!!b);
27 EXPECT_TRUE(!a); 40 EXPECT_TRUE(!a);
28 } 41 }
29 42
30 class RefCountedClass : public RefCounted<RefCountedClass> {}; 43 class RefCountedClass : public RefCounted<RefCountedClass> {};
31 44
32 TEST(RefPtrTest, ConstObject) { 45 TEST(RefPtrTest, ConstObject) {
33 // This test is only to ensure we force the compilation of a const RefCounted 46 // This test is only to ensure we force the compilation of a const RefCounted
34 // object to ensure the generated code compiles. 47 // object to ensure the generated code compiles.
35 RefPtr<const RefCountedClass> ptrToConst = adoptRef(new RefCountedClass()); 48 RefPtr<const RefCountedClass> ptrToConst = adoptRef(new RefCountedClass());
36 } 49 }
37 50
38 } // namespace WTF 51 } // namespace WTF
OLDNEW
« no previous file with comments | « third_party/WebKit/Source/wtf/RefPtr.h ('k') | third_party/WebKit/Source/wtf/text/AtomicStringTable.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698