Move media permission checking logic for ChromeOS login pages

chrome/browser/chromeos/login/ui/webui_login_view.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/chromeos/login/ui/webui_login_view.h"
 
+#include <unordered_set>
+
 #include "ash/common/focus_cycler.h"
 #include "ash/common/system/status_area_widget_delegate.h"
 #include "ash/common/system/tray/system_tray.h"
 #include "ash/common/wm_shell.h"
 #include "ash/shell.h"
 #include "base/bind.h"
 #include "base/callback.h"
 #include "base/i18n/rtl.h"
 #include "base/logging.h"
 #include "base/macros.h"
 #include "base/strings/utf_string_conversions.h"
 #include "base/trace_event/trace_event.h"
 #include "base/values.h"
 #include "chrome/browser/chrome_notification_types.h"
 #include "chrome/browser/chromeos/accessibility/accessibility_util.h"
 #include "chrome/browser/chromeos/app_mode/kiosk_app_manager.h"
 #include "chrome/browser/chromeos/login/ui/login_display_host_impl.h"
 #include "chrome/browser/chromeos/login/ui/preloaded_web_view.h"
 #include "chrome/browser/chromeos/login/ui/preloaded_web_view_factory.h"
 #include "chrome/browser/chromeos/login/ui/proxy_settings_dialog.h"
 #include "chrome/browser/chromeos/login/ui/web_contents_forced_title.h"
 #include "chrome/browser/chromeos/login/ui/web_contents_set_background_color.h"
 #include "chrome/browser/chromeos/login/ui/webui_login_display.h"
 #include "chrome/browser/chromeos/profiles/profile_helper.h"
-#include "chrome/browser/chromeos/settings/cros_settings.h"
 #include "chrome/browser/extensions/chrome_extension_web_contents_observer.h"
 #include "chrome/browser/media/webrtc/media_capture_devices_dispatcher.h"
 #include "chrome/browser/media/webrtc/media_stream_devices_controller.h"
 #include "chrome/browser/password_manager/chrome_password_manager_client.h"
 #include "chrome/browser/renderer_preferences_util.h"
 #include "chrome/browser/sessions/session_tab_helper.h"
 #include "chrome/browser/ui/ash/ash_util.h"
 #include "chrome/browser/ui/ash/system_tray_client.h"
 #include "chrome/browser/ui/autofill/chrome_autofill_client.h"
 #include "chrome/browser/ui/webui/chromeos/login/oobe_ui.h"
 #include "chromeos/dbus/dbus_thread_manager.h"
 #include "chromeos/dbus/session_manager_client.h"
 #include "chromeos/network/network_state.h"
 #include "chromeos/network/network_state_handler.h"
-#include "chromeos/settings/cros_settings_names.h"
 #include "components/content_settings/core/common/content_settings_pattern.h"
 #include "components/password_manager/core/browser/password_manager.h"
 #include "components/web_modal/web_contents_modal_dialog_manager.h"
 #include "content/public/browser/notification_service.h"
 #include "content/public/browser/render_frame_host.h"
 #include "content/public/browser/render_view_host.h"
 #include "content/public/browser/render_widget_host.h"
 #include "content/public/browser/render_widget_host_view.h"
 #include "content/public/browser/web_contents.h"
 #include "content/public/browser/web_ui.h"
@@ skipping 53 matching lines @@
 
 // A helper method returns status area widget delegate if exists,
 // otherwise nullptr.
 ash::StatusAreaWidgetDelegate* GetStatusAreaWidgetDelegate() {
   ash::SystemTray* tray = ash::Shell::GetInstance()->GetPrimarySystemTray();
   return tray ? static_cast<ash::StatusAreaWidgetDelegate*>(
                     tray->GetWidget()->GetContentsView())
               : nullptr;
 }
 
+std::unordered_set<const content::WebContentsDelegate*>*
+GetWebUILoginViewSet() {
+  CR_DEFINE_STATIC_LOCAL(
+      std::unordered_set<const content::WebContentsDelegate*>,
+      g_webui_login_view_set, ());
+  return &g_webui_login_view_set;
+}
+
 }  // namespace
 
 namespace chromeos {
 
 // static
 const char WebUILoginView::kViewClassName[] =
     "browser/chromeos/login/WebUILoginView";
 
 // WebUILoginView::CycleFocusTraversable ---------------------------------------
 class WebUILoginView::CycleFocusTraversable : public views::FocusTraversable {
@@ skipping 43 matching lines @@
 
  private:
   WebUILoginView* const webui_login_view_;
   views::FocusSearch status_area_focus_search_;
 
   DISALLOW_COPY_AND_ASSIGN(StatusAreaFocusTraversable);
 };
 
 // WebUILoginView public: ------------------------------------------------------
 
+// static
+bool WebUILoginView::IsWebUILoginView(
+    const content::WebContentsDelegate* delegate) {
+  return base::ContainsKey(*GetWebUILoginViewSet(), delegate);
+}
+
 WebUILoginView::WebUILoginView(const WebViewSettings& settings)
     : settings_(settings) {
+  auto was_added = GetWebUILoginViewSet()->insert(this);
+  DCHECK(was_added.second);
+
   registrar_.Add(this,
                  chrome::NOTIFICATION_LOGIN_OR_LOCK_WEBUI_VISIBLE,
                  content::NotificationService::AllSources());
   registrar_.Add(this,
                  chrome::NOTIFICATION_LOGIN_NETWORK_ERROR_SHOWN,
                  content::NotificationService::AllSources());
 
   accel_map_[ui::Accelerator(ui::VKEY_ESCAPE, ui::EF_NONE)] =
       kAccelNameCancel;
   accel_map_[ui::Accelerator(ui::VKEY_E,
@@ skipping 40 matching lines @@
 
   accel_map_[ui::Accelerator(
       ui::VKEY_S, ui::EF_CONTROL_DOWN | ui::EF_ALT_DOWN | ui::EF_SHIFT_DOWN)] =
       kAccelNameBootstrappingSlave;
 
   for (AccelMap::iterator i(accel_map_.begin()); i != accel_map_.end(); ++i)
     AddAccelerator(i->first);
 }
 
 WebUILoginView::~WebUILoginView() {
+  size_t num_removed = GetWebUILoginViewSet()->erase(this);
+  DCHECK_EQ(1u, num_removed);
+
   for (auto& observer : observer_list_)
     observer.OnHostDestroying();
 
   if (!chrome::IsRunningInMash() &&
       ash::Shell::GetInstance()->HasPrimaryStatusArea()) {
     views::Widget* tray_widget =
         ash::Shell::GetInstance()->GetPrimarySystemTray()->GetWidget();
     ash::StatusAreaWidgetDelegate* status_area_widget_delegate =
         static_cast<ash::StatusAreaWidgetDelegate*>(
             tray_widget->GetContentsView());
@@ skipping 300 matching lines @@
         reverse ? ash::FocusCycler::BACKWARD : ash::FocusCycler::FORWARD);
   }
 
   return true;
 }
 
 void WebUILoginView::RequestMediaAccessPermission(
     WebContents* web_contents,
     const content::MediaStreamRequest& request,
     const content::MediaResponseCallback& callback) {
+  // Note: This is only needed for SAML logins.
   MediaStreamDevicesController controller(web_contents, request, callback);
-  if (!controller.IsAskingForAudio() && !controller.IsAskingForVideo())
-    return;
-
-  if (controller.IsAskingForAudio()) {
-    controller.PermissionDenied();
-    return;
-  }
-
-  const CrosSettings* const settings = CrosSettings::Get();
-  if (!settings) {
-    controller.PermissionDenied();
-    return;
-  }
-
-  const base::Value* const raw_list_value =
-      settings->GetPref(kLoginVideoCaptureAllowedUrls);
-  if (!raw_list_value) {
-    controller.PermissionDenied();
-    return;
-  }
-
-  const base::ListValue* list_value;
-  CHECK(raw_list_value->GetAsList(&list_value));
-  for (const auto& base_value : *list_value) {
-    std::string value;
-    if (base_value->GetAsString(&value)) {
-      ContentSettingsPattern pattern =
-          ContentSettingsPattern::FromString(value);
-      if (pattern == ContentSettingsPattern::Wildcard()) {
-        LOG(WARNING) << "Ignoring wildcard URL pattern: " << value;
-        continue;
-      }
-      if (pattern.IsValid() && pattern.Matches(request.security_origin)) {
-        controller.PermissionGranted();
-        return;
-      }
-    }
-  }
-  controller.PermissionDenied();
+  DCHECK(!controller.IsAskingForAudio() && !controller.IsAskingForVideo());
 }
 
 bool WebUILoginView::CheckMediaAccessPermission(
     content::WebContents* web_contents,
     const GURL& security_origin,
     content::MediaStreamType type) {
   return MediaCaptureDevicesDispatcher::GetInstance()
       ->CheckMediaAccessPermission(web_contents, security_origin, type);
 }
 
@@ skipping 16 matching lines @@
   if (should_emit_login_prompt_visible_) {
     VLOG(1) << "Login WebUI >> login-prompt-visible";
     chromeos::DBusThreadManager::Get()->GetSessionManagerClient()->
         EmitLoginPromptVisible();
   }
 
   webui_visible_ = true;
 }
 
 }  // namespace chromeos