pkg/polymer_expressions/test/eval_test.dart - Issue 26967004: add @MirrorsUsed to observe/polymer/polymer_exprs pkgs

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: pkg/polymer_expressions/test/eval_test.dart

Issue 26967004: add @MirrorsUsed to observe/polymer/polymer_exprs pkgs (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: fix typo in comment Created 7 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« pkg/polymer_expressions/lib/src/mirrors.dart ('K') | « pkg/polymer_expressions/test/bindings_test.dart ('k') | pkg/polymer_expressions/test/syntax_test.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: pkg/polymer_expressions/test/eval_test.dart

diff --git a/pkg/polymer_expressions/test/eval_test.dart b/pkg/polymer_expressions/test/eval_test.dart

index d69a123dc44a66e9862e84307c63b9b0bf0223eb..f18ccec735769c639a1c89953a30a4d1ec079100 100644

--- a/pkg/polymer_expressions/test/eval_test.dart

+++ b/pkg/polymer_expressions/test/eval_test.dart

@@ -6,6 +6,10 @@ library eval_test;

import 'dart:async';

+// NOTE: this import is unused, but we use it to cause all mirrors to be

+// enabled. The tests reflect on LinkedHashMap.length and String.length.

+import 'dart:mirrors';

import 'package:polymer_expressions/eval.dart';

import 'package:polymer_expressions/filter.dart';

import 'package:polymer_expressions/parser.dart';

@@ -325,7 +329,8 @@ main() {

}

-class Foo extends Object with ChangeNotifierMixin {

+@reflectable

+class Foo extends ChangeNotifierBase {

String _name;

String get name => _name;

void set name(String n) {

@@ -395,5 +400,5 @@ expectObserve(String s, {

// Regression test from https://code.google.com/p/dart/issues/detail?id=13459

class WordElement extends ObservableBase {

@observable List chars1 = 'abcdefg'.split('');

- List filteredList(List original) => [original[0], original[1]];

+ @reflectable List filteredList(List original) => [original[0], original[1]];

}