Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(363)

Unified Diff: media/blink/webmediaplayer_impl.h

Issue 2696663002: Media Remoting: Don't auto suspend the media pipeline. (Closed)
Patch Set: Disable other auto suspend for optimization. Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: media/blink/webmediaplayer_impl.h
diff --git a/media/blink/webmediaplayer_impl.h b/media/blink/webmediaplayer_impl.h
index 1b184a88858d488d68fbde6c0f5684c791cad08d..c41101baef2411e8da99b3f61adfbcfa0c476953 100644
--- a/media/blink/webmediaplayer_impl.h
+++ b/media/blink/webmediaplayer_impl.h
@@ -88,6 +88,7 @@ class MEDIA_BLINK_EXPORT WebMediaPlayerImpl
: public NON_EXPORTED_BASE(blink::WebMediaPlayer),
public NON_EXPORTED_BASE(WebMediaPlayerDelegate::Observer),
public NON_EXPORTED_BASE(Pipeline::Client),
+ public MediaObserverClient,
public base::SupportsWeakPtr<WebMediaPlayerImpl> {
public:
// Constructs a WebMediaPlayer implementation using Chromium's media stack.
@@ -214,19 +215,15 @@ class MEDIA_BLINK_EXPORT WebMediaPlayerImpl
void SetUseFallbackPath(bool use_fallback_path);
#endif
+ // MediaObserverClient implementation.
+ void SwitchRenderer() override;
+ void ActivateViewportIntersectionMonitoring(bool activate) override;
+ void DisablePipelineAutoSuspend(bool disable) override;
+
// Called from WebMediaPlayerCast.
// TODO(hubbe): WMPI_CAST make private.
void OnPipelineSeeked(bool time_updated);
- // Restart the player/pipeline as soon as possible. This will destroy the
- // current renderer, if any, and create a new one via the RendererFactory; and
- // then seek to resume playback at the current position.
- void ScheduleRestart();
-
- // Called when requests to activate monitoring changes on viewport
- // intersection.
- void ActivateViewportIntersectionMonitoring(bool activate);
-
// Distinct states that |delegate_| can be in. (Public for testing.)
enum class DelegateState {
GONE,
@@ -296,6 +293,11 @@ class MEDIA_BLINK_EXPORT WebMediaPlayerImpl
// Finishes starting the pipeline due to a call to load().
void StartPipeline();
+ // Restart the player/pipeline as soon as possible. This will destroy the
+ // current renderer, if any, and create a new one via the RendererFactory; and
+ // then seek to resume playback at the current position.
+ void ScheduleRestart();
+
// Helpers that set the network/ready state and notifies the client if
// they've changed.
void SetNetworkState(blink::WebMediaPlayer::NetworkState state);
@@ -689,6 +691,9 @@ class MEDIA_BLINK_EXPORT WebMediaPlayerImpl
// Whether the pipeline is being resumed at the moment.
bool is_pipeline_resuming_ = false;
+ // When this is true, pipeline will not be auto suspended.
+ bool disable_pipeline_auto_suspend_ = false;
+
// Pipeline statistics overridden by tests.
base::Optional<PipelineStatistics> pipeline_statistics_for_test_;

Powered by Google App Engine
This is Rietveld 408576698