Media Remoting: Don't auto suspend the media pipeline.

media/blink/webmediaplayer_impl.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "media/blink/webmediaplayer_impl.h"
 
 #include <algorithm>
 #include <cmath>
 #include <limits>
 #include <string>
@@ skipping 249 matching lines @@
   media_log_->AddEvent(
       media_log_->CreateEvent(MediaLogEvent::WEBMEDIAPLAYER_CREATED));
 
   if (params.initial_cdm())
     SetCdm(params.initial_cdm());
 
   // TODO(xhwang): When we use an external Renderer, many methods won't work,
   // e.g. GetCurrentFrameFromCompositor(). See http://crbug.com/434861
   audio_source_provider_ =
       new WebAudioSourceProviderImpl(params.audio_renderer_sink(), media_log_);
+
+  if (observer_)
+    observer_->SetClient(this);
 }
 
 WebMediaPlayerImpl::~WebMediaPlayerImpl() {
   DCHECK(main_task_runner_->BelongsToCurrentThread());
 
   suppress_destruction_errors_ = true;
 
   delegate_->PlayerGone(delegate_id_);
   delegate_->RemoveObserver(delegate_id_);
 
@@ skipping 1551 matching lines @@
 }
 
 void WebMediaPlayerImpl::UpdatePlayState() {
   DCHECK(main_task_runner_->BelongsToCurrentThread());
 
 #if defined(OS_ANDROID)  // WMPI_CAST
   bool is_remote = isRemote();
   bool is_streaming = false;
 #else
   bool is_remote = false;
-  bool is_streaming = IsStreaming();
+  bool is_streaming = IsStreaming() || disable_pipeline_auto_suspend_;

[miu, 2017/02/13 23:36:08]

This |is_streaming| variable should probably be renamed to something like
|can_auto_suspend|:

  bool can_auto_suspend = !disable_pipeline_auto_suspend_ && !IsStreaming();

(and, of course, that means inverting the true/false everywhere downsteream).

Also, s/is_streaming/can_auto_suspend/ in the args of
UpdatePlayState_ComputePlayState() and inverting the meaning there too.

[xjz, 2017/02/14 01:46:10]

Done.

 #endif
 
   bool is_suspended = pipeline_controller_.IsSuspended();
   bool is_backgrounded = IsBackgroundedSuspendEnabled() && IsHidden();
   PlayState state = UpdatePlayState_ComputePlayState(
       is_remote, is_streaming, is_suspended, is_backgrounded);
   SetDelegateState(state.delegate_state, state.is_idle);
   SetMemoryReportingState(state.is_memory_reporting_enabled);
   SetSuspendState(state.is_suspended || pending_suspend_resume_cycle_);
 }
@@ skipping 428 matching lines @@
   if (hasAudio()) {
     UMA_HISTOGRAM_TIMES(
         "Media.Video.TimeFromForegroundToFirstFrame.DisableTrack",
         time_to_first_frame);
   } else {
     UMA_HISTOGRAM_TIMES("Media.Video.TimeFromForegroundToFirstFrame.Paused",
                         time_to_first_frame);
   }
 }
 
+void WebMediaPlayerImpl::SwitchRenderer() {
+  DCHECK(main_task_runner_->BelongsToCurrentThread());
+  ScheduleRestart();
+}
+
+void WebMediaPlayerImpl::DisablePipelineAutoSuspend(bool disable) {
+  DCHECK(main_task_runner_->BelongsToCurrentThread());
+  disable_pipeline_auto_suspend_ = disable;
+}
+
 }  // namespace media