Media Remoting: Don't auto suspend the media pipeline.

media/base/media_observer.h

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef MEDIA_BASE_MEDIA_OBSERVER_H_
 #define MEDIA_BASE_MEDIA_OBSERVER_H_
 
 #include "media/base/cdm_context.h"
 #include "media/base/pipeline_metadata.h"
 #include "url/gurl.h"
 
 namespace media {
 
+class MEDIA_EXPORT MediaObserverClient {
+ public:
+  virtual ~MediaObserverClient() {}
+
+  // Requests to restart the media pipeline and create a new renderer as soon as
+  // possible.
+  virtual void SwitchRenderer() = 0;

[miu, 2017/02/13 23:36:08]

Observation: It seems both SwitchRenderer() and DisablePipelineAutoSuspend() are
always called together.

Suggestion: How about just have one SwitchRenderer() method that takes a "bool
disable_auto_suspend" argument, rather than these two separate methods? This
would simplify code in both RendererController and WMPI.

[xjz, 2017/02/14 01:46:10]

Done. I did observe this too. But I was not sure whether we should combine these
two in the interface design, since these two are not necessarily always called
together. After an offline discussion, I agree with this suggestion, since they
are now always called together and can both control the pipeline.

+
+  // Requests to activate monitoring changes on viewport intersection.
+  virtual void ActivateViewportIntersectionMonitoring(bool activate) = 0;
+
+  // Requests to disable pipeline auto suspend for optimization.
+  virtual void DisablePipelineAutoSuspend(bool disable) = 0;
+};
+
 // This class is an observer of media player events.
 class MEDIA_EXPORT MediaObserver {
  public:
   MediaObserver();
   virtual ~MediaObserver();
 
   // Called when the media element entered/exited fullscreen.
   virtual void OnEnteredFullscreen() = 0;
   virtual void OnExitedFullscreen() = 0;
 
@@ skipping 14 matching lines @@
   // Remote Playback API spec: https://w3c.github.io/remote-playback
   virtual void OnRemotePlaybackDisabled(bool disabled) = 0;
 
   // Called when the media is playing/paused.
   virtual void OnPlaying() = 0;
   virtual void OnPaused() = 0;
 
   // Called when a poster image URL is set, which happens when media is loaded
   // or the poster attribute is changed.
   virtual void OnSetPoster(const GURL& poster) = 0;
+
+  // Set the MediaObserverClient.
+  virtual void SetClient(MediaObserverClient* client) = 0;
 };
 
 }  // namespace media
 
 #endif  // MEDIA_BASE_MEDIA_OBSERVER_H_