Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(33)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 269663010: Disabled FeedbackTest.ShowFeedback. (Closed)

Created:
6 years, 7 months ago by Matt Giuca
Modified:
6 years, 7 months ago
Reviewers:
benwells
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org, chrome-apps-syd-reviews_chromium.org
Visibility:
Public.

Description

Disabled FeedbackTest.ShowFeedback. It is crashing ChromiumOS build bots intermittently. BUG=369886 TBR=benwells@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=268130

Patch Set 1 #

Patch Set 2 : Rebase. #

Patch Set 3 : Disable only on ChromeOS. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -1 line) Patch
M chrome/browser/extensions/api/feedback_private/feedback_browsertest.cc View 1 2 1 chunk +9 lines, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
Matt Giuca
Committed patchset #3 manually as r268130 (tree was closed).
6 years, 7 months ago (2014-05-05 00:39:12 UTC) #1
Matt Giuca
Not sure if I was supposed to send this review out before committing it...
6 years, 7 months ago (2014-05-05 00:41:15 UTC) #2
benwells
On 2014/05/05 00:41:15, Matt Giuca wrote: > Not sure if I was supposed to send ...
6 years, 7 months ago (2014-05-05 00:56:51 UTC) #3
benwells
6 years, 7 months ago (2014-05-05 00:57:10 UTC) #4
Message was sent while issue was closed. 
lgtm

Powered by Google App Engine
This is Rietveld 408576698