Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(342)

Unified Diff: chrome/browser/about_flags.cc

Issue 2696563002: [NTP::SectionOrder] Add EM oriented order. (Closed)
Patch Set: treib@ comments. Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/about_flags.cc
diff --git a/chrome/browser/about_flags.cc b/chrome/browser/about_flags.cc
index c5d84898a3d423039fa00bc6e28e8d04c4550ea3..3285335770aabdf39e8e50cfc8b43f26fb545ed4 100644
--- a/chrome/browser/about_flags.cc
+++ b/chrome/browser/about_flags.cc
@@ -499,6 +499,28 @@ const FeatureEntry::Choice kNtpSwitchToExistingTabChoices[] = {
#if defined(OS_ANDROID)
const FeatureEntry::FeatureParam
+ kContentSuggestionsCategoryOrderFeatureVariationGeneral[] = {
+ {ntp_snippets::kCategoryOrderParameter,
+ ntp_snippets::kCategoryOrderGeneral},
+};
+
+const FeatureEntry::FeatureParam
+ kContentSuggestionsCategoryOrderFeatureVariationEMOriented[] = {
+ {ntp_snippets::kCategoryOrderParameter,
+ ntp_snippets::kCategoryOrderEmergingMarketsOriented},
+};
+
+const FeatureEntry::FeatureVariation
+ kContentSuggestionsCategoryOrderFeatureVariations[] = {
+ {"(general)", kContentSuggestionsCategoryOrderFeatureVariationGeneral,
+ arraysize(kContentSuggestionsCategoryOrderFeatureVariationGeneral),
+ nullptr},
+ {"(emerging markets oriented)",
+ kContentSuggestionsCategoryOrderFeatureVariationEMOriented,
+ arraysize(kContentSuggestionsCategoryOrderFeatureVariationEMOriented),
+ nullptr}};
+
+const FeatureEntry::FeatureParam
kContentSuggestionsCategoryRankerFeatureVariationConstant[] = {
{ntp_snippets::kCategoryRankerParameter,
ntp_snippets::kCategoryRankerConstantRanker},
@@ -1832,6 +1854,16 @@ const FeatureEntry kFeatureEntries[] = {
SINGLE_VALUE_TYPE(extensions::switches::kDisableTabForDesktopShare)},
#endif // ENABLE_EXTENSIONS
#if defined(OS_ANDROID)
+ // TODO(vitaliii): Use ntp_snippets::kStudyName as the feature trial.
+ // Currently, only a single FEATURE_WITH_VARIATIONS_VALUE_TYPE can use a
+ // given study name. See crbug.com/690450.
+ {"content-suggestions-category-order",
+ IDS_FLAGS_CONTENT_SUGGESTIONS_CATEGORY_ORDER_NAME,
+ IDS_FLAGS_CONTENT_SUGGESTIONS_CATEGORY_ORDER_DESCRIPTION, kOsAndroid,
+ FEATURE_WITH_VARIATIONS_VALUE_TYPE(
+ ntp_snippets::kCategoryOrder,
+ kContentSuggestionsCategoryOrderFeatureVariations,
+ "content-suggestions-category-order-feature-trial")},
{"content-suggestions-category-ranker",
IDS_FLAGS_CONTENT_SUGGESTIONS_CATEGORY_RANKER_NAME,
IDS_FLAGS_CONTENT_SUGGESTIONS_CATEGORY_RANKER_DESCRIPTION, kOsAndroid,

Powered by Google App Engine
This is Rietveld 408576698