Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(162)

Unified Diff: third_party/WebKit/Source/web/WebViewImpl.cpp

Issue 2696523003: Unify the code paths for handling mouse events when pointer is locked on (Closed)
Patch Set: remove null check Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/WebKit/Source/web/WebViewImpl.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/web/WebViewImpl.cpp
diff --git a/third_party/WebKit/Source/web/WebViewImpl.cpp b/third_party/WebKit/Source/web/WebViewImpl.cpp
index 598a7cd95fdc1fad932260e3682c3a41a666aa2a..6dc0e376cb0b3cb7a50f9a0b7437f727cf424722 100644
--- a/third_party/WebKit/Source/web/WebViewImpl.cpp
+++ b/third_party/WebKit/Source/web/WebViewImpl.cpp
@@ -2170,7 +2170,7 @@ WebInputEventResult WebViewImpl::handleInputEvent(
}
if (isPointerLocked && WebInputEvent::isMouseEventType(inputEvent.type())) {
- pointerLockMouseEvent(inputEvent);
+ mainFrameImpl()->frameWidget()->pointerLockMouseEvent(inputEvent);
return WebInputEventResult::HandledSystem;
}
@@ -2523,19 +2523,15 @@ void WebViewImpl::willCloseLayerTreeView() {
}
void WebViewImpl::didAcquirePointerLock() {
- if (page())
- page()->pointerLockController().didAcquirePointerLock();
+ mainFrameImpl()->frameWidget()->didAcquirePointerLock();
}
void WebViewImpl::didNotAcquirePointerLock() {
- if (page())
- page()->pointerLockController().didNotAcquirePointerLock();
+ mainFrameImpl()->frameWidget()->didNotAcquirePointerLock();
}
void WebViewImpl::didLosePointerLock() {
- m_pointerLockGestureToken.clear();
- if (page())
- page()->pointerLockController().didLosePointerLock();
+ mainFrameImpl()->frameWidget()->didLosePointerLock();
}
// TODO(ekaramad):This method is almost duplicated in WebFrameWidgetImpl as
@@ -4085,42 +4081,6 @@ void WebViewImpl::setCompositorVisibility(bool isVisible) {
m_layerTreeView->setVisible(isVisible);
}
-void WebViewImpl::pointerLockMouseEvent(const WebInputEvent& event) {
- std::unique_ptr<UserGestureIndicator> gestureIndicator;
- AtomicString eventType;
- switch (event.type()) {
- case WebInputEvent::MouseDown:
- eventType = EventTypeNames::mousedown;
- if (!page() || !page()->pointerLockController().element())
- break;
- gestureIndicator = WTF::wrapUnique(
- new UserGestureIndicator(DocumentUserGestureToken::create(
- &page()->pointerLockController().element()->document(),
- UserGestureToken::NewGesture)));
- m_pointerLockGestureToken = gestureIndicator->currentToken();
- break;
- case WebInputEvent::MouseUp:
- eventType = EventTypeNames::mouseup;
- gestureIndicator = WTF::wrapUnique(
- new UserGestureIndicator(m_pointerLockGestureToken.release()));
- break;
- case WebInputEvent::MouseMove:
- eventType = EventTypeNames::mousemove;
- break;
- default:
- NOTREACHED();
- }
-
- const WebMouseEvent& mouseEvent = static_cast<const WebMouseEvent&>(event);
-
- if (page()) {
- WebMouseEvent transformedEvent =
- TransformWebMouseEvent(mainFrameImpl()->frameView(), mouseEvent);
- page()->pointerLockController().dispatchLockedMouseEvent(transformedEvent,
- eventType);
- }
-}
-
void WebViewImpl::forceNextWebGLContextCreationToFail() {
WebGLRenderingContext::forceNextWebGLContextCreationToFail();
}
« no previous file with comments | « third_party/WebKit/Source/web/WebViewImpl.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698