Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(264)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2696513003: Add output_type_test (Closed)

Created:
3 years, 10 months ago by Johnni Winther
Modified:
3 years, 10 months ago
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Add output_type_test - in preparation for refactoring of CompilerOutput R=sigmund@google.com Committed: https://github.com/dart-lang/sdk/commit/fd918a2725a5330cfb11fb14528092c61eb5ecc0

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+148 lines, -12 lines) Patch
M pkg/compiler/lib/src/inferrer/debug.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/source_file_provider.dart View 2 chunks +9 lines, -5 lines 0 comments Download
M pkg/compiler/lib/src/tracer.dart View 2 chunks +14 lines, -6 lines 0 comments Download
A tests/compiler/dart2js/data/deferred_helper.dart View 1 chunk +10 lines, -0 lines 0 comments Download
A tests/compiler/dart2js/data/deferred_lib.dart View 1 chunk +7 lines, -0 lines 0 comments Download
A tests/compiler/dart2js/output_type_test.dart View 1 chunk +107 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
Johnni Winther
3 years, 10 months ago (2017-02-13 13:11:36 UTC) #3
Siggi Cherem (dart-lang)
lgt
3 years, 10 months ago (2017-02-14 23:01:22 UTC) #4
Siggi Cherem (dart-lang)
m lgtm
3 years, 10 months ago (2017-02-14 23:01:27 UTC) #5
Johnni Winther
3 years, 10 months ago (2017-02-20 09:04:01 UTC) #7
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as
fd918a2725a5330cfb11fb14528092c61eb5ecc0 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698