Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8)

Unified Diff: components/navigation_interception/intercept_navigation_throttle_unittest.cc

Issue 2696493003: Introduce SubframeNavigationFilteringThrottle (Closed)
Patch Set: fix use after stack return, make code nicer Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/navigation_interception/intercept_navigation_throttle_unittest.cc
diff --git a/components/navigation_interception/intercept_navigation_throttle_unittest.cc b/components/navigation_interception/intercept_navigation_throttle_unittest.cc
index a6d27c4945d517894e1d68dc88e5570dc530345c..4bd3845acad7deb762442581b50500503ae9a238 100644
--- a/components/navigation_interception/intercept_navigation_throttle_unittest.cc
+++ b/components/navigation_interception/intercept_navigation_throttle_unittest.cc
@@ -71,7 +71,8 @@ class InterceptNavigationThrottleTest
base::Unretained(mock_callback_receiver_.get())),
true));
return test_handle->CallWillStartRequestForTesting(
- is_post, content::Referrer(), false, ui::PAGE_TRANSITION_LINK, false);
+ is_post, content::Referrer(), false, ui::PAGE_TRANSITION_LINK, false,
+ content::NavigationHandle::ThrottleChecksFinishedCallback());
}
NavigationThrottle::ThrottleCheckResult Simulate302() {
@@ -85,9 +86,11 @@ class InterceptNavigationThrottleTest
base::Unretained(mock_callback_receiver_.get())),
true));
test_handle->CallWillStartRequestForTesting(
- true, content::Referrer(), false, ui::PAGE_TRANSITION_LINK, false);
- return test_handle->CallWillRedirectRequestForTesting(GURL(kTestUrl), false,
- GURL(), false);
+ true, content::Referrer(), false, ui::PAGE_TRANSITION_LINK, false,
+ content::NavigationHandle::ThrottleChecksFinishedCallback());
+ return test_handle->CallWillRedirectRequestForTesting(
+ GURL(kTestUrl), false, GURL(), false,
+ content::NavigationHandle::ThrottleChecksFinishedCallback());
}
std::unique_ptr<MockInterceptCallbackReceiver> mock_callback_receiver_;

Powered by Google App Engine
This is Rietveld 408576698