Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(79)

Side by Side Diff: components/subresource_filter/content/browser/subframe_filtering_navigation_throttle.cc

Issue 2696493003: Introduce SubframeNavigationFilteringThrottle (Closed)
Patch Set: fix test names Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
(Empty)
1 // Copyright 2017 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file.
4
5 #include "components/subresource_filter/content/browser/subframe_filtering_navig ation_throttle.h"
6
7 #include "base/bind.h"
8 #include "components/subresource_filter/content/browser/async_document_subresour ce_filter.h"
9 #include "content/public/browser/navigation_handle.h"
10
11 namespace subresource_filter {
12
13 SubframeFilteringNavigationThrottle::SubframeFilteringNavigationThrottle(
14 content::NavigationHandle* handle,
15 AsyncDocumentSubresourceFilter* async_filter)
pkalinnikov 2017/02/14 12:11:07 nit: Rename to |parent_filter| too (see comment in
Charlie Harrison 2017/02/14 14:09:38 Done.
16 : content::NavigationThrottle(handle),
17 parent_filter_(async_filter),
18 weak_ptr_factory_(this) {
19 DCHECK(!handle->IsInMainFrame());
20 DCHECK(parent_filter_);
21 }
22
23 SubframeFilteringNavigationThrottle::~SubframeFilteringNavigationThrottle() {}
24
25 content::NavigationThrottle::ThrottleCheckResult
26 SubframeFilteringNavigationThrottle::WillStartRequest() {
27 return DeferToCalculateLoadPolicy();
28 }
29
30 content::NavigationThrottle::ThrottleCheckResult
31 SubframeFilteringNavigationThrottle::WillRedirectRequest() {
32 return DeferToCalculateLoadPolicy();
33 }
34
35 content::NavigationThrottle::ThrottleCheckResult
36 SubframeFilteringNavigationThrottle::DeferToCalculateLoadPolicy() {
37 parent_filter_->GetLoadPolicyForSubdocument(
38 navigation_handle()->GetURL(),
39 base::Bind(&SubframeFilteringNavigationThrottle::OnCalculatedLoadPolicy,
40 weak_ptr_factory_.GetWeakPtr()));
41 return content::NavigationThrottle::ThrottleCheckResult::DEFER;
42 }
43
44 void SubframeFilteringNavigationThrottle::OnCalculatedLoadPolicy(
45 blink::WebDocumentSubresourceFilter::LoadPolicy policy) {
46 // TODO(csharrison): Support WouldDisallow pattern and expose the policy for
47 // metrics.
48 if (policy == blink::WebDocumentSubresourceFilter::Disallow) {
49 navigation_handle()->CancelDeferredNavigation(
50 content::NavigationThrottle::CANCEL);
pkalinnikov 2017/02/14 12:11:07 We should also to call parent_filter_->ReportDisal
Charlie Harrison 2017/02/14 14:09:38 Done.
51 } else {
52 navigation_handle()->Resume();
53 }
54 }
55
56 } // namespace subresource_filter
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698