Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Unified Diff: net/socket/client_socket_pool_base.cc

Issue 2696403007: Add a multiplier in tracking certificate memory allocation size (Closed)
Patch Set: Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | net/socket/ssl_client_socket_impl.cc » ('j') | net/socket/ssl_client_socket_impl.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/socket/client_socket_pool_base.cc
diff --git a/net/socket/client_socket_pool_base.cc b/net/socket/client_socket_pool_base.cc
index c5427ccf7a621906788859ab7d4bb647d90539ed..c4f3d9c88d651fdda4ca63bd5a8cb6d6705c1b70 100644
--- a/net/socket/client_socket_pool_base.cc
+++ b/net/socket/client_socket_pool_base.cc
@@ -708,7 +708,7 @@ void ClientSocketPoolBaseHelper::DumpMemoryStats(
size_t total_size = 0;
size_t buffer_size = 0;
size_t cert_count = 0;
- size_t serialized_cert_size = 0;
+ size_t cert_size = 0;
for (const auto& kv : group_map_) {
for (const auto& socket : kv.second->idle_sockets()) {
StreamSocket::SocketMemoryStats stats;
@@ -716,7 +716,7 @@ void ClientSocketPoolBaseHelper::DumpMemoryStats(
total_size += stats.total_size;
buffer_size += stats.buffer_size;
cert_count += stats.cert_count;
- serialized_cert_size += stats.serialized_cert_size;
+ cert_size += stats.cert_size;
++socket_count;
}
}
@@ -738,9 +738,8 @@ void ClientSocketPoolBaseHelper::DumpMemoryStats(
"cert_count", base::trace_event::MemoryAllocatorDump::kUnitsObjects,
cert_count);
socket_pool_dump->AddScalar(
- "serialized_cert_size",
- base::trace_event::MemoryAllocatorDump::kUnitsBytes,
- serialized_cert_size);
+ "undeduped_cert_size",
+ base::trace_event::MemoryAllocatorDump::kUnitsBytes, cert_size);
}
}
« no previous file with comments | « no previous file | net/socket/ssl_client_socket_impl.cc » ('j') | net/socket/ssl_client_socket_impl.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698