Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(212)

Issue 2696403005: DevTools: Add thread selector to timeline tree views. (Closed)

Created:
3 years, 10 months ago by alph
Modified:
3 years, 10 months ago
Reviewers:
kozy, caseq
CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, pfeldman, kozyatinskiy+blink_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

DevTools: Add thread selector to timeline tree views. Review-Url: https://codereview.chromium.org/2696403005 Cr-Commit-Position: refs/heads/master@{#451164} Committed: https://chromium.googlesource.com/chromium/src/+/7c72af3f79ee04521ea3aadb0a8448bb0644ca0f

Patch Set 1 #

Total comments: 4

Patch Set 2 : 4 landing #

Unified diffs Side-by-side diffs Delta from patch set Stats (+50 lines, -5 lines) Patch
M third_party/WebKit/Source/devtools/front_end/timeline/TimelineTreeView.js View 1 6 chunks +50 lines, -5 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
alph
3 years, 10 months ago (2017-02-16 19:21:36 UTC) #2
caseq
lgtm https://codereview.chromium.org/2696403005/diff/1/third_party/WebKit/Source/devtools/front_end/timeline/TimelineTreeView.js File third_party/WebKit/Source/devtools/front_end/timeline/TimelineTreeView.js (right): https://codereview.chromium.org/2696403005/diff/1/third_party/WebKit/Source/devtools/front_end/timeline/TimelineTreeView.js#newcode129 third_party/WebKit/Source/devtools/front_end/timeline/TimelineTreeView.js:129: this._threadSelector = new UI.ToolbarComboBox(targetChanged.bind(this)); consider UI.ToolbarSettingComboBox if this ...
3 years, 10 months ago (2017-02-16 20:07:43 UTC) #3
alph
https://codereview.chromium.org/2696403005/diff/1/third_party/WebKit/Source/devtools/front_end/timeline/TimelineTreeView.js File third_party/WebKit/Source/devtools/front_end/timeline/TimelineTreeView.js (right): https://codereview.chromium.org/2696403005/diff/1/third_party/WebKit/Source/devtools/front_end/timeline/TimelineTreeView.js#newcode129 third_party/WebKit/Source/devtools/front_end/timeline/TimelineTreeView.js:129: this._threadSelector = new UI.ToolbarComboBox(targetChanged.bind(this)); On 2017/02/16 20:07:42, caseq wrote: ...
3 years, 10 months ago (2017-02-16 21:28:13 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2696403005/20001
3 years, 10 months ago (2017-02-16 21:33:29 UTC) #7
commit-bot: I haz the power
3 years, 10 months ago (2017-02-17 01:12:17 UTC) #10
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/7c72af3f79ee04521ea3aadb0a84...

Powered by Google App Engine
This is Rietveld 408576698