Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(534)

Issue 26964002: Fix touch hit rect position for table cells (Closed)

Created:
7 years, 2 months ago by Rick Byers
Modified:
7 years, 2 months ago
CC:
blink-reviews, eae+blinkwatch, leviw+renderwatch, jchaffraix+rendering
Visibility:
Public.

Description

Fix touch hit rect position for table cells RenderTableCell is unusual in that its location offset includes the offset of its parent row. We compensate for this in other places (like offsetFromContainer), and so this CL also compensates for this in touch hit rect generation. BUG=300283 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=159498

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -0 lines) Patch
M LayoutTests/fast/events/touch/compositor-touch-hit-rects.html View 2 chunks +8 lines, -0 lines 0 comments Download
M LayoutTests/fast/events/touch/compositor-touch-hit-rects-expected.txt View 1 chunk +2 lines, -0 lines 0 comments Download
M LayoutTests/platform/linux/fast/events/touch/compositor-touch-hit-rects-expected.txt View 1 chunk +2 lines, -0 lines 0 comments Download
M Source/core/rendering/RenderTableCell.h View 1 chunk +2 lines, -0 lines 0 comments Download
M Source/core/rendering/RenderTableCell.cpp View 1 chunk +10 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Rick Byers
Levi, Please review this little touch hit rect fix. Before and after screenshots of the ...
7 years, 2 months ago (2013-10-11 02:29:22 UTC) #1
leviw_travelin_and_unemployed
lgtm
7 years, 2 months ago (2013-10-11 20:58:34 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rbyers@chromium.org/26964002/1
7 years, 2 months ago (2013-10-11 20:58:51 UTC) #3
commit-bot: I haz the power
7 years, 2 months ago (2013-10-12 05:08:58 UTC) #4
Message was sent while issue was closed.
Change committed as 159498

Powered by Google App Engine
This is Rietveld 408576698