Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1910)

Unified Diff: cc/resources/tile_manager.cc

Issue 269633006: Revert of cc: Change required_for_activation bookkeeping. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « cc/layers/picture_layer_impl.cc ('k') | cc/test/fake_tile_manager_client.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: cc/resources/tile_manager.cc
diff --git a/cc/resources/tile_manager.cc b/cc/resources/tile_manager.cc
index eb389c544c871189cd444a27ff1dbbd51b4de41a..38948c3fa1ab921b01864c448fb5e7fb3d74ee65 100644
--- a/cc/resources/tile_manager.cc
+++ b/cc/resources/tile_manager.cc
@@ -675,8 +675,7 @@
// should keep it in the prioritized tile set to ensure that AssignGpuMemory
// can visit it.
if (mts.bin == NEVER_BIN &&
- !mts.tile_versions[mts.raster_mode].raster_task_ &&
- !tile->required_for_activation()) {
+ !mts.tile_versions[mts.raster_mode].raster_task_) {
FreeResourcesForTile(tile);
continue;
}
@@ -841,7 +840,6 @@
size_t max_raster_bytes = max_raster_usage_bytes_ / 2;
size_t raster_bytes = 0;
- int processed_required_for_activation_tile_count = 0;
unsigned schedule_priority = 1u;
for (PrioritizedTileSet::Iterator it(tiles, true); it; ++it) {
Tile* tile = *it;
@@ -861,8 +859,6 @@
// If the tile is not needed, free it up.
if (mts.bin == NEVER_BIN) {
FreeResourcesForTile(tile);
- if (tile->required_for_activation())
- ++processed_required_for_activation_tile_count;
continue;
}
@@ -921,10 +917,8 @@
hard_bytes_left -= tile_bytes;
soft_bytes_left =
(soft_bytes_left > tile_bytes) ? soft_bytes_left - tile_bytes : 0;
- if (tile_version.resource_) {
- DCHECK(tile->IsReadyToDraw());
+ if (tile_version.resource_)
continue;
- }
}
DCHECK(!tile_version.resource_);
@@ -943,29 +937,15 @@
if (!can_schedule_tile) {
all_tiles_that_need_to_be_rasterized_have_memory_ = false;
+ if (tile->required_for_activation())
+ all_tiles_required_for_activation_have_memory_ = false;
it.DisablePriorityOrdering();
continue;
}
raster_bytes = raster_bytes_if_rastered;
tiles_that_need_to_be_rasterized->push_back(tile);
- if (tile->required_for_activation())
- ++processed_required_for_activation_tile_count;
- }
-
- int total_required_for_activation_tile_count = 0;
- for (std::vector<PictureLayerImpl*>::const_iterator it = layers_.begin();
- it != layers_.end();
- ++it) {
- if ((*it)->GetTree() == PENDING_TREE) {
- total_required_for_activation_tile_count +=
- (*it)->UninitializedTilesRequiredForActivationCount();
- }
- }
-
- all_tiles_required_for_activation_have_memory_ =
- processed_required_for_activation_tile_count ==
- total_required_for_activation_tile_count;
+ }
// OOM reporting uses hard-limit, soft-OOM is normal depending on limit.
ever_exceeded_memory_budget_ |= oomed_hard;
« no previous file with comments | « cc/layers/picture_layer_impl.cc ('k') | cc/test/fake_tile_manager_client.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698