Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(265)

Issue 269633006: Revert of cc: Change required_for_activation bookkeeping. (Closed)

Created:
6 years, 7 months ago by Ken Russell (switch to Gerrit)
Modified:
6 years, 7 months ago
Reviewers:
reveman, vmpstr, enne (OOO)
CC:
chromium-reviews, cc-bugs_chromium.org, Ken Russell (switch to Gerrit), bajones, Zhenyao Mo, alokp
Visibility:
Public.

Description

Revert of cc: Change required_for_activation bookkeeping. (https://codereview.chromium.org/257773009/) Reason for revert: Caused context_lost tests to hang on Win and Mac GPU bots. See original CL for links to failing builds. Original issue's description: > cc: Change required_for_activation bookkeeping. > > This patch changes the bookkeeping of whether required for activation > tiles all received memory during AssignGpuMemory. The new approach > doesn't rely on the fact that we process every tile in that loop, thus > allowing us to early out or use another approach at getting tiles that > does not guarantee that every tile will be visited. > > The end goal is to evaluate if we can activate when the rasterizer > notifies us that all tasks given to it that are required for > activation are finished rather than trying to figure this out > when we schedule tasks. > > R=reveman, enne > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=267400 TBR=enne@chromium.org,reveman@chromium.org,vmpstr@chromium.org NOTREECHECKS=true NOTRY=true Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=267521

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -55 lines) Patch
M cc/layers/picture_layer_impl.h View 3 chunks +2 lines, -12 lines 0 comments Download
M cc/layers/picture_layer_impl.cc View 6 chunks +4 lines, -16 lines 0 comments Download
M cc/resources/tile_manager.cc View 5 chunks +5 lines, -25 lines 0 comments Download
M cc/test/fake_tile_manager_client.h View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Ken Russell (switch to Gerrit)
Created Revert of cc: Change required_for_activation bookkeeping.
6 years, 7 months ago (2014-05-01 13:12:38 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kbr@chromium.org/269633006/1
6 years, 7 months ago (2014-05-01 13:12:47 UTC) #2
commit-bot: I haz the power
Change committed as 267521
6 years, 7 months ago (2014-05-01 13:13:26 UTC) #3
Ted C
6 years, 7 months ago (2014-05-01 18:40:06 UTC) #4
Message was sent while issue was closed.
On 2014/05/01 13:13:26, I haz the power (commit-bot) wrote:
> Change committed as 267521

I believe this revert also fixed:
https://code.google.com/p/chromium/issues/detail?id=369126

So you probably want to verify that behavior on Android before relanding,

Powered by Google App Engine
This is Rietveld 408576698