Tests for analysis.navigation.

Tests for analysis.navigation.

BUG=
R=brianwilkerson@google.com, scheglov@google.com

Committed: https://github.com/dart-lang/sdk/commit/5e0710617db02e5d2d5e3ea433d303141203ed55

[devoncarew, 2017-02-16 09:38:08]

devoncarew@google.com changed reviewers:
+ brianwilkerson@google.com, scheglov@google.com

[devoncarew, 2017-02-16 09:38:08]

Tests for:
- analysis.getNavigation
- analysis.setAnalysisRoots
- analysis.setSubscriptions
- analysis.updateOptions

The negative test for analysis.getNavigation fails. I've investigate but haven't
determined why. I'm passing in valid source and an offset into whitespace; I
would expect to get no results back. Is this expected from the API?

From looking at the implementation, it looks like the driver and non-driver
paths are different; the non-driver paths collects navigations from plugins, and
the driver path does not. Could very well be reading this wrong however.

I can't commit this as is - I will need to fix or remove the negative
analysis.getNavigation test.

[Brian Wilkerson, 2017-02-16 14:57:43]

lgtm

> I will need to fix or remove the negative analysis.getNavigation test.

Or just mark it with "@failingTest".

https://codereview.chromium.org/2696323004/diff/1/pkg/analysis_server/test/in...
File pkg/analysis_server/test/integration/analysis/update_options_test.dart
(right):

https://codereview.chromium.org/2696323004/diff/1/pkg/analysis_server/test/in...
pkg/analysis_server/test/integration/analysis/update_options_test.dart:28: await
sendAnalysisUpdateOptions(new AnalysisOptions());
A better test would be to let everything be analyzed with default options, then
change the options in a way that would add or remove errors so that we can see
that the options were actually applied.

https://codereview.chromium.org/2696323004/diff/1/pkg/analysis_server/test/in...
File pkg/analysis_server/test/integration/integration_tests.dart (right):

https://codereview.chromium.org/2696323004/diff/1/pkg/analysis_server/test/in...
pkg/analysis_server/test/integration/integration_tests.dart:724: // integration
tests, and would like speed the tests up as well.
But then they wouldn't be true integration tests.

[scheglov, 2017-02-16 15:13:52]

lgtm

[devoncarew, 2017-02-16 22:33:02]

Thanks for the tip on @failingTest! I added such, and filed associated issues to
track.

https://codereview.chromium.org/2696323004/diff/1/pkg/analysis_server/test/in...
File pkg/analysis_server/test/integration/analysis/update_options_test.dart
(right):

https://codereview.chromium.org/2696323004/diff/1/pkg/analysis_server/test/in...
pkg/analysis_server/test/integration/analysis/update_options_test.dart:28: await
sendAnalysisUpdateOptions(new AnalysisOptions());
On 2017/02/16 14:57:43, Brian Wilkerson wrote:
> A better test would be to let everything be analyzed with default options,
then
> change the options in a way that would add or remove errors so that we can see
> that the options were actually applied.

Yup, good idea. I updated this to set and unset the generateHints flag (also
found what looks like a bug).

[devoncarew, 2017-02-16 22:35:25]

Description was changed from

==========
Tests for analysis.navigation.

BUG=
==========

to

==========
Tests for analysis.navigation.

BUG=
R=brianwilkerson@google.com, scheglov@google.com

Committed:
https://github.com/dart-lang/sdk/commit/5e0710617db02e5d2d5e3ea433d303141203ed55
==========

[devoncarew, 2017-02-16 22:35:27]

Committed patchset #2 (id:20001) manually as
5e0710617db02e5d2d5e3ea433d303141203ed55 (presubmit successful).