content/shell/android/java/src/org/chromium/content_shell/Shell.java - Issue 2696303004: Android screen orientation lock should lock/unlock the same activity

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/shell/android/java/src/org/chromium/content_shell/Shell.java

Issue 2696303004: Android screen orientation lock should lock/unlock the same activity (Closed)

Patch Set: Add data deps to chrome_test_java Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/public/android/javatests/src/org/chromium/content/browser/VideoFullscreenOrientationLockTest.java ('k') | third_party/WebKit/Source/core/html/shadow/MediaControlsOrientationLockDelegate.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/shell/android/java/src/org/chromium/content_shell/Shell.java

diff --git a/content/shell/android/java/src/org/chromium/content_shell/Shell.java b/content/shell/android/java/src/org/chromium/content_shell/Shell.java

index 6215bf40ac63039f7b4018d7e9163cb88148ca28..f2afcfbd240c8d51a7d5d9764815c9022a410725 100644

--- a/content/shell/android/java/src/org/chromium/content_shell/Shell.java

+++ b/content/shell/android/java/src/org/chromium/content_shell/Shell.java

@@ -356,13 +356,17 @@ public class Shell extends LinearLayout {

@Override

public void enterFullscreenVideo(View view, boolean isVideoLoaded) {

super.enterFullscreenVideo(view, isVideoLoaded);

- mContentViewRenderView.setOverlayVideoMode(true);

+ if (mContentViewRenderView != null) {

+ mContentViewRenderView.setOverlayVideoMode(true);

+ }

}

@Override

public void exitFullscreenVideo() {

super.exitFullscreenVideo();

- mContentViewRenderView.setOverlayVideoMode(false);

+ if (mContentViewRenderView != null) {

+ mContentViewRenderView.setOverlayVideoMode(false);

+ }

}

};

}