content/public/android/javatests/src/org/chromium/content/browser/ScreenOrientationListenerTest.java - Issue 2696303004: Android screen orientation lock should lock/unlock the same activity

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/public/android/javatests/src/org/chromium/content/browser/ScreenOrientationListenerTest.java

Issue 2696303004: Android screen orientation lock should lock/unlock the same activity (Closed)

Patch Set: Add data deps to chrome_test_java Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/public/android/java/src/org/chromium/content/browser/ScreenOrientationProvider.java ('k') | content/public/android/javatests/src/org/chromium/content/browser/VideoFullscreenOrientationLockTest.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/public/android/javatests/src/org/chromium/content/browser/ScreenOrientationListenerTest.java

diff --git a/content/public/android/javatests/src/org/chromium/content/browser/ScreenOrientationListenerTest.java b/content/public/android/javatests/src/org/chromium/content/browser/ScreenOrientationListenerTest.java

index 4f3e373e891b8432ccc9aee2283dfe7452307a57..a03f016171021734d489c73c22c18f22b1fd702a 100644

--- a/content/public/android/javatests/src/org/chromium/content/browser/ScreenOrientationListenerTest.java

+++ b/content/public/android/javatests/src/org/chromium/content/browser/ScreenOrientationListenerTest.java

@@ -229,7 +229,8 @@ public class ScreenOrientationListenerTest extends ContentShellTestBase {

ThreadUtils.runOnUiThreadBlocking(new Runnable() {

@Override

public void run() {

- ScreenOrientationProvider.lockOrientation(null, (byte) orientationValue);

+ ScreenOrientationProvider.lockOrientation(

+ getContentViewCore().getWindowAndroid(), (byte) orientationValue);

}

});

mCallbackHelper.waitForCallback(callCount);