DevTools: disable the Chrome tab debugging warning for force-installed extensions.

chrome/browser/extensions/api/debugger/debugger_api.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // Implements the Chrome Extensions Debugger API.
 
 #include "chrome/browser/extensions/api/debugger/debugger_api.h"
 
 #include <stddef.h>
 
@@ skipping 18 matching lines @@
 #include "chrome/browser/devtools/chrome_devtools_manager_delegate.h"
 #include "chrome/browser/devtools/global_confirm_info_bar.h"
 #include "chrome/browser/extensions/api/debugger/debugger_api_constants.h"
 #include "chrome/browser/extensions/extension_service.h"
 #include "chrome/browser/extensions/extension_tab_util.h"
 #include "chrome/browser/infobars/infobar_service.h"
 #include "chrome/browser/profiles/profile.h"
 #include "chrome/browser/ui/browser.h"
 #include "chrome/browser/ui/webui/chrome_web_ui_controller_factory.h"
 #include "chrome/common/chrome_switches.h"
+#include "chrome/common/pref_names.h"
 #include "chrome/grit/generated_resources.h"
 #include "components/infobars/core/confirm_infobar_delegate.h"
 #include "components/infobars/core/infobar.h"
 #include "content/public/browser/browser_thread.h"
 #include "content/public/browser/devtools_agent_host.h"
 #include "content/public/browser/notification_service.h"
 #include "content/public/browser/notification_source.h"
 #include "content/public/browser/render_process_host.h"
 #include "content/public/browser/render_view_host.h"
 #include "content/public/browser/render_widget_host.h"
 #include "content/public/browser/web_contents.h"
 #include "content/public/common/content_client.h"
 #include "content/public/common/url_utils.h"
 #include "extensions/browser/event_router.h"
 #include "extensions/browser/extension_host.h"
 #include "extensions/browser/extension_registry.h"
 #include "extensions/browser/extension_registry_observer.h"
+#include "extensions/browser/extension_system.h"
 #include "extensions/common/constants.h"
 #include "extensions/common/error_utils.h"
 #include "extensions/common/extension.h"
 #include "extensions/common/manifest_constants.h"
 #include "extensions/common/permissions/permissions_data.h"
 #include "extensions/common/switches.h"
 #include "ui/base/l10n/l10n_util.h"
 
 using content::DevToolsAgentHost;
 using content::RenderProcessHost;
@@ skipping 268 matching lines @@
 
   // RVH-based agents disconnect from their clients when the app is terminating
   // but shared worker-based agents do not.
   // Disconnect explicitly to make sure that |this| observer is not leaked.
   registrar_.Add(this, chrome::NOTIFICATION_APP_TERMINATING,
                  content::NotificationService::AllSources());
 
   // Attach to debugger and tell it we are ready.
   agent_host_->AttachClient(this);
 
-  if (!base::CommandLine::ForCurrentProcess()->HasSwitch(
+  if (base::CommandLine::ForCurrentProcess()->HasSwitch(
           ::switches::kSilentDebuggerExtensionAPI)) {
-    infobar_ = ExtensionDevToolsInfoBar::Create(
-        extension_id, extension_name, this,
-        base::Bind(&ExtensionDevToolsClientHost::InfoBarDismissed,
-                   base::Unretained(this)));
+    return;
   }
+
+  if (profile->GetPrefs()->GetBoolean(
+          prefs::kDevToolsSilentManagedDebuggerAPIEnabled)) {

[Andrew T Wilson (Slow), 2017/02/22 11:13:42]

IMO, this new policy is unnecessary and we should just hide this UI for all
policy-installed extensions. But let's see what privacy folks think.

Also, the tests check to see that we are setting a pref based on the policy, but
don't actually check that the UI is shown/hidden. I'm not dogmatic about this,
but would be nice if we had a test that actually set the policy and verified the
UI didn't show up.

[Devlin, 2017/02/22 13:53:48]

That was Pavel's original suggestion, but I pushed back because I and others
were uncomfortable with effectively opting-in every enterprise to this new
behavior.  Some enterprises may desire, or even depend, on this UI to keep users
informed.

[pfeldman, 2017/02/22 16:40:45]

I don't have a strong opinion on this one, as Devlin mentions that was my
original intention. But in policy is safer and not expensive to maintain, we can
have it.

+    const Extension* extension =
+        ExtensionRegistry::Get(profile)->enabled_extensions().GetByID(
+            extension_id);
+    if (Manifest::IsPolicyLocation(extension->location()))
+      return;
+  }
+
+  infobar_ = ExtensionDevToolsInfoBar::Create(
+      extension_id, extension_name, this,
+      base::Bind(&ExtensionDevToolsClientHost::InfoBarDismissed,
+                 base::Unretained(this)));
 }
 
 ExtensionDevToolsClientHost::~ExtensionDevToolsClientHost() {
   if (infobar_)
     infobar_->Remove(this);
   g_attached_client_hosts.Get().erase(this);
 }
 
 // DevToolsAgentHostClient implementation.
 void ExtensionDevToolsClientHost::AgentHostClosed(
@@ skipping 368 matching lines @@
 void DebuggerGetTargetsFunction::SendTargetList(
     const content::DevToolsAgentHost::List& target_list) {
   std::unique_ptr<base::ListValue> result(new base::ListValue());
   for (size_t i = 0; i < target_list.size(); ++i)
     result->Append(SerializeTarget(target_list[i]));
   SetResult(std::move(result));
   SendResponse(true);
 }
 
 }  // namespace extensions