ui/views/layout/layout_constants.h - Issue 2696263002: Refactor ViewsDelegate and MD-ify the icon-to-text spacing for checkbox and radiobutton

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ui/views/layout/layout_constants.h

Issue 2696263002: Refactor ViewsDelegate and MD-ify the icon-to-text spacing for checkbox and radiobutton (Closed)

Patch Set: Added GetDefaultSpacingMetric to ViewsDelegate to start process of hiding layout constants Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: ui/views/layout/layout_constants.h

diff --git a/ui/views/layout/layout_constants.h b/ui/views/layout/layout_constants.h

index e375ad7f08be10ed9f54751cd8e9899d034221da..ee1b0d2e7811862e9e12fc3c215b243eebac68a7 100644

--- a/ui/views/layout/layout_constants.h

+++ b/ui/views/layout/layout_constants.h

@@ -71,7 +71,7 @@ constexpr int kButtonVEdgeMarginNew = 20;

constexpr int kButtonHEdgeMarginNew = 20;

// Spacing between the edge of the window and the edge of the close button.

-const int kCloseButtonMargin = 7;

+constexpr int kCloseButtonMargin = 7;

// Horizontal spacing between buttons that are logically related.

constexpr int kRelatedButtonHSpacing = 6;

@@ -84,7 +84,7 @@ constexpr int kCheckboxIndent = 10;

constexpr int kItemLabelSpacing = 10;

// Minimum width of dialog buttons.

-const int kDialogMinimumButtonWidth = 75;

+constexpr int kDialogMinimumButtonWidth = 75;

} // namespace views