ui/views/bubble/bubble_frame_view.cc - Issue 2696263002: Refactor ViewsDelegate and MD-ify the icon-to-text spacing for checkbox and radiobutton

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ui/views/bubble/bubble_frame_view.cc

Issue 2696263002: Refactor ViewsDelegate and MD-ify the icon-to-text spacing for checkbox and radiobutton (Closed)

Patch Set: Reduced ViewsDelegate layout/metric functions to only two functions Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: ui/views/bubble/bubble_frame_view.cc

diff --git a/ui/views/bubble/bubble_frame_view.cc b/ui/views/bubble/bubble_frame_view.cc

index 14f5622aba174aeff0115960fd7b8cb22cf925a6..79223f920ffd0b0449c216573f1b48e6b4102b40 100644

--- a/ui/views/bubble/bubble_frame_view.cc

+++ b/ui/views/bubble/bubble_frame_view.cc

@@ -314,8 +314,8 @@ void BubbleFrameView::Layout() {

return;

// The close button is positioned somewhat closer to the edge of the bubble.

- const int close_margin =

- ViewsDelegate::GetInstance()->GetDialogCloseButtonMargin();

+ const int close_margin = ViewsDelegate::GetInstance()->GetSpacingMetric(

+ ViewsDelegate::SpacingMetric::CLOSE_BUTTON_MARGIN);

close_->SetPosition(

gfx::Point(contents_bounds.right() - close_margin - close_->width(),

contents_bounds.y() + close_margin));