Refactor ViewsDelegate and MD-ify the icon-to-text spacing for checkbox and radiobutton

content/public/test/test_renderer_host.cc

Index: content/public/test/test_renderer_host.cc
diff --git a/content/public/test/test_renderer_host.cc b/content/public/test/test_renderer_host.cc
index 91354a1caec4d702618cc932f8a2b3fa171aea28..47b934b4a25c2d93f11bd2a858ef66082e5f4226 100644
--- a/content/public/test/test_renderer_host.cc
+++ b/content/public/test/test_renderer_host.cc
@@ -265,7 +265,7 @@ void RenderViewHostTestHarness::SetUp() {
   ui::MaterialDesignController::Initialize();
   thread_bundle_.reset(new TestBrowserThreadBundle(thread_bundle_options_));
 
-  rvh_test_enabler_.reset(new RenderViewHostTestEnabler);
+  rvh_test_enabler_.reset(new RenderViewHostTestEnabler());

[sky, 2017/02/28 20:11:52]

Revert this change?

[Peter Kasting, 2017/03/01 06:32:36]

Didn't chromium-dev have a long thread about this a while back and how usually
people should use the () form unless they really, really knew what they were
doing?  I can't seem to find it in gmail search though.

[sky, 2017/03/01 17:07:16]

I don't remember that, but it's certainly possible I msised it. If the () is
preferable, keep it. Although for my knowledge could you give me the quick
synopsis as why the () is preferable?

[kylix_rd, 2017/03/01 17:33:27]

That is likely correct because IIRC, this was changed by running git cl format.

[Peter Kasting, 2017/03/01 23:32:23]

From memory, () zero-inits certain objects and no-() leaves the members as
garbage?

   if (factory_)
     rvh_test_enabler_->rvh_factory_->set_render_process_host_factory(factory_);