Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(160)

Side by Side Diff: chrome/browser/ui/views/harmony/layout_delegate.h

Issue 2696263002: Refactor ViewsDelegate and MD-ify the icon-to-text spacing for checkbox and radiobutton (Closed)
Patch Set: Reduced ViewsDelegate layout/metric functions to only two functions Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2016 The Chromium Authors. All rights reserved. 1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_BROWSER_UI_VIEWS_HARMONY_LAYOUT_DELEGATE_H_ 5 #ifndef CHROME_BROWSER_UI_VIEWS_HARMONY_LAYOUT_DELEGATE_H_
6 #define CHROME_BROWSER_UI_VIEWS_HARMONY_LAYOUT_DELEGATE_H_ 6 #define CHROME_BROWSER_UI_VIEWS_HARMONY_LAYOUT_DELEGATE_H_
7 7
8 #include "ui/views/layout/grid_layout.h" 8 #include "ui/views/layout/grid_layout.h"
9 9
10 class LayoutDelegate { 10 class LayoutDelegate {
(...skipping 22 matching lines...) Expand all
33 // Horizontal spacing between an item such as an icon or checkbox and a 33 // Horizontal spacing between an item such as an icon or checkbox and a
34 // label related to it. 34 // label related to it.
35 RELATED_LABEL_HORIZONTAL_SPACING, 35 RELATED_LABEL_HORIZONTAL_SPACING,
36 // Horizontal indent of a subsection relative to related items above, e.g. 36 // Horizontal indent of a subsection relative to related items above, e.g.
37 // checkboxes below explanatory text/headings. 37 // checkboxes below explanatory text/headings.
38 SUBSECTION_HORIZONTAL_INDENT, 38 SUBSECTION_HORIZONTAL_INDENT,
39 // Vertical spacing between controls that are logically unrelated. 39 // Vertical spacing between controls that are logically unrelated.
40 UNRELATED_CONTROL_VERTICAL_SPACING, 40 UNRELATED_CONTROL_VERTICAL_SPACING,
41 // Larger vertical spacing between unrelated controls. 41 // Larger vertical spacing between unrelated controls.
42 UNRELATED_CONTROL_VERTICAL_SPACING_LARGE, 42 UNRELATED_CONTROL_VERTICAL_SPACING_LARGE,
43 // Horizontal spacing between the image/icon on a label button and its
44 // associated text. This includes checkboxes and radio buttons.
45 ICON_TEXT_SPACING,
43 }; 46 };
44 47
45 enum class DialogWidth { 48 enum class DialogWidth {
46 SMALL, 49 SMALL,
47 MEDIUM, 50 MEDIUM,
48 LARGE, 51 LARGE,
49 }; 52 };
50 53
51 LayoutDelegate() {} 54 LayoutDelegate() {}
52 virtual ~LayoutDelegate() {} 55 virtual ~LayoutDelegate() {}
(...skipping 29 matching lines...) Expand all
82 85
83 // Returns the preferred width in DIPs for a dialog of the specified |width|. 86 // Returns the preferred width in DIPs for a dialog of the specified |width|.
84 // May return 0 if the dialog has no preferred width. 87 // May return 0 if the dialog has no preferred width.
85 virtual int GetDialogPreferredWidth(DialogWidth width) const; 88 virtual int GetDialogPreferredWidth(DialogWidth width) const;
86 89
87 private: 90 private:
88 DISALLOW_COPY_AND_ASSIGN(LayoutDelegate); 91 DISALLOW_COPY_AND_ASSIGN(LayoutDelegate);
89 }; 92 };
90 93
91 #endif // CHROME_BROWSER_UI_VIEWS_HARMONY_LAYOUT_DELEGATE_H_ 94 #endif // CHROME_BROWSER_UI_VIEWS_HARMONY_LAYOUT_DELEGATE_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698