Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(423)

Side by Side Diff: chrome/browser/first_run/try_chrome_dialog_view.cc

Issue 2696263002: Refactor ViewsDelegate and MD-ify the icon-to-text spacing for checkbox and radiobutton (Closed)
Patch Set: Fix unit tests to use a ViewsDelegate to guard against crashes Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/first_run/try_chrome_dialog_view.h" 5 #include "chrome/browser/first_run/try_chrome_dialog_view.h"
6 6
7 #include <shellapi.h> 7 #include <shellapi.h>
8 8
9 #include "base/logging.h" 9 #include "base/logging.h"
10 #include "base/macros.h" 10 #include "base/macros.h"
(...skipping 16 matching lines...) Expand all
27 #include "ui/views/background.h" 27 #include "ui/views/background.h"
28 #include "ui/views/controls/button/checkbox.h" 28 #include "ui/views/controls/button/checkbox.h"
29 #include "ui/views/controls/button/image_button.h" 29 #include "ui/views/controls/button/image_button.h"
30 #include "ui/views/controls/button/md_text_button.h" 30 #include "ui/views/controls/button/md_text_button.h"
31 #include "ui/views/controls/button/radio_button.h" 31 #include "ui/views/controls/button/radio_button.h"
32 #include "ui/views/controls/image_view.h" 32 #include "ui/views/controls/image_view.h"
33 #include "ui/views/controls/link.h" 33 #include "ui/views/controls/link.h"
34 #include "ui/views/controls/separator.h" 34 #include "ui/views/controls/separator.h"
35 #include "ui/views/layout/grid_layout.h" 35 #include "ui/views/layout/grid_layout.h"
36 #include "ui/views/layout/layout_constants.h" 36 #include "ui/views/layout/layout_constants.h"
37 #include "ui/views/views_delegate.h"
37 #include "ui/views/widget/widget.h" 38 #include "ui/views/widget/widget.h"
38 39
39 namespace { 40 namespace {
40 41
41 const wchar_t kHelpCenterUrl[] = 42 const wchar_t kHelpCenterUrl[] =
42 L"https://support.google.com/chrome/answer/150752"; 43 L"https://support.google.com/chrome/answer/150752";
43 44
44 enum ButtonTags { 45 enum ButtonTags {
45 BT_NONE, 46 BT_NONE,
46 BT_CLOSE_BUTTON, 47 BT_CLOSE_BUTTON,
(...skipping 80 matching lines...) Expand 10 before | Expand all | Expand 10 after
127 columns->AddPaddingColumn(0, icon_size.width()); 128 columns->AddPaddingColumn(0, icon_size.width());
128 columns->AddPaddingColumn(0, views::kRelatedControlHorizontalSpacing); 129 columns->AddPaddingColumn(0, views::kRelatedControlHorizontalSpacing);
129 columns->AddColumn(views::GridLayout::LEADING, views::GridLayout::FILL, 1, 130 columns->AddColumn(views::GridLayout::LEADING, views::GridLayout::FILL, 1,
130 views::GridLayout::USE_PREF, 0, 0); 131 views::GridLayout::USE_PREF, 0, 0);
131 132
132 // Fourth row: [pad][pad][button][pad][button]. 133 // Fourth row: [pad][pad][button][pad][button].
133 columns = layout->AddColumnSet(3); 134 columns = layout->AddColumnSet(3);
134 columns->AddPaddingColumn(0, icon_size.width()); 135 columns->AddPaddingColumn(0, icon_size.width());
135 columns->AddColumn(views::GridLayout::LEADING, views::GridLayout::FILL, 0, 136 columns->AddColumn(views::GridLayout::LEADING, views::GridLayout::FILL, 0,
136 views::GridLayout::USE_PREF, 0, 0); 137 views::GridLayout::USE_PREF, 0, 0);
137 columns->AddPaddingColumn(0, views::kRelatedButtonHSpacing); 138 columns->AddPaddingColumn(
139 0, views::ViewsDelegate::GetInstance()->GetSpacingMetric(
140 views::SpacingMetric::RELATED_HORIZONTAL_BUTTON));
138 columns->AddColumn(views::GridLayout::LEADING, views::GridLayout::FILL, 0, 141 columns->AddColumn(views::GridLayout::LEADING, views::GridLayout::FILL, 0,
139 views::GridLayout::USE_PREF, 0, 0); 142 views::GridLayout::USE_PREF, 0, 0);
140 143
141 // Fifth row: [pad][pad][link]. 144 // Fifth row: [pad][pad][link].
142 columns = layout->AddColumnSet(4); 145 columns = layout->AddColumnSet(4);
143 columns->AddPaddingColumn(0, icon_size.width()); 146 columns->AddPaddingColumn(0, icon_size.width());
144 columns->AddPaddingColumn(0, views::kRelatedControlHorizontalSpacing); 147 columns->AddPaddingColumn(0, views::kRelatedControlHorizontalSpacing);
145 columns->AddColumn(views::GridLayout::LEADING, views::GridLayout::FILL, 1, 148 columns->AddColumn(views::GridLayout::LEADING, views::GridLayout::FILL, 1,
146 views::GridLayout::USE_PREF, 0, 0); 149 views::GridLayout::USE_PREF, 0, 0);
147 150
(...skipping 213 matching lines...) Expand 10 before | Expand all | Expand 10 after
361 result_ = TRY_CHROME_AS_DEFAULT; 364 result_ = TRY_CHROME_AS_DEFAULT;
362 } 365 }
363 366
364 popup_->Close(); 367 popup_->Close();
365 base::MessageLoop::current()->QuitWhenIdle(); 368 base::MessageLoop::current()->QuitWhenIdle();
366 } 369 }
367 370
368 void TryChromeDialogView::LinkClicked(views::Link* source, int event_flags) { 371 void TryChromeDialogView::LinkClicked(views::Link* source, int event_flags) {
369 ::ShellExecuteW(NULL, L"open", kHelpCenterUrl, NULL, NULL, SW_SHOW); 372 ::ShellExecuteW(NULL, L"open", kHelpCenterUrl, NULL, NULL, SW_SHOW);
370 } 373 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698