Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(236)

Issue 2696213002: Some cleanup of AxObjectCacheImpl.cpp (Closed)

Created:
3 years, 10 months ago by aleventhal
Modified:
3 years, 10 months ago
Reviewers:
haraken, dmazzoni
CC:
chromium-reviews, aboxhall, aboxhall+watch_chromium.org, nektar+watch_chromium.org, yuzo+watch_chromium.org, blink-reviews, nektarios, je_julie, dmazzoni+watch_chromium.org, dtseng+watch_chromium.org, dmazzoni
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Some cleanup of AxObjectCacheImpl.cpp - Dry up uses of getAXID() (save result in const) - Rename getAXID() to getOrCreateAXID to show it's more than a simple getter (which usually don't have side effects). - Remove unused method ::rootObject(). - Change ASSERT to DCHECK BUG=none R=dmazzoni Review-Url: https://codereview.chromium.org/2696213002 Cr-Commit-Position: refs/heads/master@{#452668} Committed: https://chromium.googlesource.com/chromium/src/+/ac41985973c63800fd911fc6e93921676462e988

Patch Set 1 #

Total comments: 4

Patch Set 2 : Stylistic changes #

Patch Set 3 : Fix compilation/refactoring error #

Patch Set 4 : Attempt to fix try jobs #

Patch Set 5 : Rebasing #

Patch Set 6 : Rebase #

Patch Set 7 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+38 lines, -46 lines) Patch
M third_party/WebKit/Source/modules/accessibility/AXObjectCacheImpl.h View 1 2 3 4 5 6 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/modules/accessibility/AXObjectCacheImpl.cpp View 1 2 3 4 5 6 14 chunks +35 lines, -43 lines 0 comments Download
M third_party/WebKit/Source/web/WebAXObject.cpp View 1 2 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 62 (43 generated)
aleventhal
3 years, 10 months ago (2017-02-15 18:08:07 UTC) #1
dmazzoni
Thanks, these changes look good https://codereview.chromium.org/2696213002/diff/1/third_party/WebKit/Source/modules/accessibility/AXObjectCacheImpl.cpp File third_party/WebKit/Source/modules/accessibility/AXObjectCacheImpl.cpp (right): https://codereview.chromium.org/2696213002/diff/1/third_party/WebKit/Source/modules/accessibility/AXObjectCacheImpl.cpp#newcode367 third_party/WebKit/Source/modules/accessibility/AXObjectCacheImpl.cpp:367: const AXID axId = ...
3 years, 10 months ago (2017-02-15 19:03:21 UTC) #2
aleventhal
Review nits addressed
3 years, 10 months ago (2017-02-16 21:24:28 UTC) #3
dmazzoni
lgtm
3 years, 10 months ago (2017-02-17 05:15:56 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2696213002/20001
3 years, 10 months ago (2017-02-17 05:16:35 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: android_compile_dbg on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_compile_dbg/builds/214012)
3 years, 10 months ago (2017-02-17 05:36:26 UTC) #8
dmazzoni
Looks like you'll need to update WebAXObject.cpp too. No need for another review from me, ...
3 years, 10 months ago (2017-02-17 05:38:26 UTC) #9
haraken
On 2017/02/17 05:38:26, dmazzoni wrote: > Looks like you'll need to update WebAXObject.cpp too. > ...
3 years, 10 months ago (2017-02-17 05:39:00 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2696213002/40001
3 years, 10 months ago (2017-02-17 15:20:09 UTC) #13
aleventhal
On 2017/02/17 05:38:26, dmazzoni wrote: > Looks like you'll need to update WebAXObject.cpp too. > ...
3 years, 10 months ago (2017-02-17 15:21:22 UTC) #14
commit-bot: I haz the power
Try jobs failed on following builders: chromeos_amd64-generic_chromium_compile_only_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_amd64-generic_chromium_compile_only_ng/builds/284450)
3 years, 10 months ago (2017-02-17 15:58:44 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2696213002/60001
3 years, 10 months ago (2017-02-21 17:50:06 UTC) #37
commit-bot: I haz the power
Failed to apply patch for third_party/WebKit/Source/modules/accessibility/AXObjectCacheImpl.cpp: While running git apply --index -p1; error: patch failed: ...
3 years, 10 months ago (2017-02-21 18:10:02 UTC) #39
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2696213002/80001
3 years, 10 months ago (2017-02-21 18:49:19 UTC) #42
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL)
3 years, 10 months ago (2017-02-21 20:52:07 UTC) #44
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2696213002/80001
3 years, 10 months ago (2017-02-23 18:30:08 UTC) #46
commit-bot: I haz the power
Try jobs failed on following builders: ios-device on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds/159002) ios-device-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED, ...
3 years, 10 months ago (2017-02-23 18:33:28 UTC) #48
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2696213002/120001
3 years, 10 months ago (2017-02-23 23:08:33 UTC) #59
commit-bot: I haz the power
3 years, 10 months ago (2017-02-23 23:19:26 UTC) #62
Message was sent while issue was closed.
Committed patchset #7 (id:120001) as
https://chromium.googlesource.com/chromium/src/+/ac41985973c63800fd911fc6e939...

Powered by Google App Engine
This is Rietveld 408576698