Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(82)

Issue 2696133005: Add generic types to Future.forEach in DDC sdk (Closed)

Created:
3 years, 10 months ago by Leaf
Modified:
3 years, 10 months ago
Reviewers:
vsm
CC:
dev-compiler+reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Add generic types to Future.forEach in DDC sdk BUG= R=vsm@google.com Committed: https://github.com/dart-lang/sdk/commit/fd6f2cc4ccf493bf6c714fc44d3146a6a1bf089d

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+38 lines, -30 lines) Patch
M pkg/dev_compiler/lib/js/amd/dart_sdk.js View 2 chunks +9 lines, -7 lines 0 comments Download
M pkg/dev_compiler/lib/js/common/dart_sdk.js View 2 chunks +9 lines, -7 lines 0 comments Download
M pkg/dev_compiler/lib/js/es6/dart_sdk.js View 2 chunks +9 lines, -7 lines 0 comments Download
M pkg/dev_compiler/lib/js/legacy/dart_sdk.js View 2 chunks +9 lines, -7 lines 0 comments Download
M pkg/dev_compiler/lib/sdk/ddc_sdk.sum View Binary file 0 comments Download
M pkg/dev_compiler/tool/input_sdk/lib/async/future.dart View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Leaf
3 years, 10 months ago (2017-02-15 18:57:24 UTC) #2
vsm
lgtm
3 years, 10 months ago (2017-02-15 19:10:35 UTC) #3
Leaf
3 years, 10 months ago (2017-02-15 19:17:36 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
fd6f2cc4ccf493bf6c714fc44d3146a6a1bf089d (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698