Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(369)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 269613002: Cleanup: Get rid of base::WideToUTF16Hack. (Closed)

Created:
6 years, 7 months ago by Lei Zhang
Modified:
6 years, 7 months ago
Reviewers:
brettw
CC:
chromium-reviews, tfarina, erikwright+watch_chromium.org, jshin+watch_chromium.org
Visibility:
Public.

Description

Cleanup: Get rid of base::WideToUTF16Hack. BUG=23581 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=268499

Patch Set 1 #

Patch Set 2 : rebase, fix win #

Unified diffs Side-by-side diffs Delta from patch set Stats (+43 lines, -51 lines) Patch
M base/strings/utf_string_conversions.h View 1 1 chunk +0 lines, -7 lines 0 comments Download
M chrome/browser/importer/firefox_importer_browsertest.cc View 1 6 chunks +14 lines, -15 lines 0 comments Download
M chrome/browser/importer/ie_importer_browsertest_win.cc View 1 2 chunks +26 lines, -26 lines 0 comments Download
M chrome/browser/importer/importer_unittest_utils.h View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/importer/importer_unittest_utils.cc View 1 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 11 (0 generated)
Lei Zhang
6 years, 7 months ago (2014-05-01 00:09:05 UTC) #1
brettw
lgtm yay!
6 years, 7 months ago (2014-05-01 16:50:27 UTC) #2
Lei Zhang
The CQ bit was checked by thestig@chromium.org
6 years, 7 months ago (2014-05-01 18:42:25 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thestig@chromium.org/269613002/1
6 years, 7 months ago (2014-05-01 18:42:33 UTC) #4
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 7 months ago (2014-05-01 22:33:29 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel on tryserver.chromium
6 years, 7 months ago (2014-05-01 22:33:30 UTC) #6
Lei Zhang
The CQ bit was checked by thestig@chromium.org
6 years, 7 months ago (2014-05-06 04:01:44 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thestig@chromium.org/269613002/20001
6 years, 7 months ago (2014-05-06 04:02:41 UTC) #8
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). Please consider checking whether the failures are ...
6 years, 7 months ago (2014-05-06 07:35:56 UTC) #9
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #2). Please consider checking whether the failures are ...
6 years, 7 months ago (2014-05-06 09:55:37 UTC) #10
commit-bot: I haz the power
6 years, 7 months ago (2014-05-06 12:41:24 UTC) #11
Message was sent while issue was closed. 
Change committed as 268499

Powered by Google App Engine
This is Rietveld 408576698